Paths

Table of Contentst

Differential D13737

[lib] Invalidate UserIdentityCache when changing FID
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 16, 8:52 PM.

Tags

None

Referenced Files

	F2999322: D13737.diff
	Thu, Oct 17, 10:22 PM

	F2993251: D13737.id45239.diff
	Thu, Oct 17, 6:35 AM

	F2993094: D13737.id.diff
	Thu, Oct 17, 6:21 AM

	F2992855: D13737.id.diff
	Thu, Oct 17, 5:40 AM

	F2992821: D13737.id45239.diff
	Thu, Oct 17, 5:14 AM

	F2992675: D13737.diff
	Thu, Oct 17, 4:31 AM

Subscribers

Details

Reviewers

Commits

rCOMM8086a05f54b8: [lib] Invalidate UserIdentityCache when changing FID

Summary

When we change the current user's FID, we should invalidate their entry in the UserIdentityCache. Otherwise, FarcasterDataHandler will continue to use the old value, and can end up wiping the FID if handleCurrentUserFID is run again before the app is killed (this can happen if the app is backgrounded/foregrounded).

This addresses ENG-9704.

Depends on D13736

Test Plan

Open mobile app when Farcaster account not linked
Link Farcaster account
Background the app
Foreground the app
Confirm that the Farcaster account is not unlinked

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 16, 8:52 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 16, 8:52 PM

ashoat added a child revision: D13738: [lib] Use setLocalFID when updating local FID to match identity.Wed, Oct 16, 8:56 PM

Harbormaster completed remote builds in B32282: Diff 45239.Wed, Oct 16, 9:28 PM

ashoat requested review of this revision.Wed, Oct 16, 9:28 PM

will accepted this revision.Wed, Oct 16, 10:42 PM

This revision is now accepted and ready to land.Wed, Oct 16, 10:42 PM

Closed by commit rCOMM8086a05f54b8: [lib] Invalidate UserIdentityCache when changing FID (authored by ashoat). · Explain WhyThu, Oct 17, 6:58 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8086a05f54b8: [lib] Invalidate UserIdentityCache when changing FID.

Revision Contents
Changeset List

Path

Size

lib/

components/

user-identity-cache.react.js

9 lines

utils/

farcaster-utils.js

8 lines

Diff 45239

lib/components/user-identity-cache.react.js

Loading...

lib/utils/farcaster-utils.js

Loading...