Page MenuHomePhabricator
Differential D13741

[lib] Delete users for whom identity didnt return a device list for a long time
ClosedPublic
Actions

Authored by inka on Oct 17 2024, 4:22 AM.
Tags
None
Referenced Files
F5121410: D13741.id45288.diff
Thu, Apr 3, 10:41 AM
F5120476: D13741.id.diff
Thu, Apr 3, 8:08 AM
F5120151: D13741.id45245.diff
Thu, Apr 3, 6:50 AM
F5119776: D13741.id45295.diff
Thu, Apr 3, 4:39 AM
F5117969: D13741.id45257.diff
Wed, Apr 2, 9:04 PM
Unknown Object (File)
Wed, Apr 2, 9:09 AM
Unknown Object (File)
Feb 28 2025, 6:06 AM
Unknown Object (File)
Feb 28 2025, 5:25 AM
View All 86 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMda9fc92ba039: [lib] Delete users for whom identity didnt return a device list for a long time
Summary

issue: ENG-9632
If we fail to fetch usres device list for a whole day, we can assume that this is not due to identity temporary data inconsistency. And if a user is a member of a DM, and their device list is not present on the identity, then we know for certain that they deleted their account.
There is only one catch here - if the request times out we shouldn't be deleting the user. Created ENG-9725 to address this

Test Plan

Tested that a user whose device list failed to be fetched for a long time gets deleted and they get removed from threads, users store and aux user store.
Checked that a user whose lastChecked was updated does not get removed from threads and other stores

Diff Detail

Repository
rCOMM Comm
Branch
inka/missing_peers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 17 2024, 4:22 AM
Herald added a subscriber: ashoat. · View Herald TranscriptOct 17 2024, 4:22 AM
inka added a parent revision: D13740: [lib] Reduce removePeerUsersActionType in thread reducer.Oct 17 2024, 4:22 AM
Harbormaster completed remote builds in B32287: Diff 45245.Oct 17 2024, 4:40 AM
inka requested review of this revision.Oct 17 2024, 4:40 AM
inka updated this revision to Diff 45257.Oct 17 2024, 6:28 AM

Rebase

Harbormaster completed remote builds in B32295: Diff 45257.Oct 17 2024, 6:54 AM
inka added a child revision: D13750: [lib] Handle identity timeout when fetching device lists.Oct 18 2024, 3:36 AM
tomek accepted this revision.Oct 21 2024, 3:41 AM
tomek added inline comments.
lib/shared/dm-ops/dm-op-utils.js
178–202

It might be a good idea to make the dependency between nonDeletedUsers and deletedUsers explicit by creating a function.

This revision is now accepted and ready to land.Oct 21 2024, 3:41 AM
inka updated this revision to Diff 45288.Oct 21 2024, 5:25 AM

Rebase, address review

Harbormaster completed remote builds in B32314: Diff 45288.Oct 21 2024, 5:44 AM
Closed by commit rCOMMda9fc92ba039: [lib] Delete users for whom identity didnt return a device list for a long time (authored by inka). · Explain WhyOct 21 2024, 6:42 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMda9fc92ba039: [lib] Delete users for whom identity didnt return a device list for a long time.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
52 lines
2 lines

Diff 45257

View Options

lib/shared/dm-ops/dm-op-utils.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
threadIsPending, threadIsPending,
parsePendingThreadID, parsePendingThreadID,
createPendingThread, createPendingThread,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
▲ Show 20 Lines • Show All 214 Lines • ▼ Show 20 Lines): Promise<ServerWebInitialReduxStateResponse> {
const finalUserInfosPromise = (async () => { const finalUserInfosPromise = (async () => {
if (excludedData.userStore) { if (excludedData.userStore) {
return {}; return {};
} }
return await userInfosPromise; return await userInfosPromise;
})(); })();
const navInfoPromise = (async () => { const navInfoPromise = (async () => {
const [ const [{ threadInfos }, currentUserInfo, userInfos, finalNavInfo] =
{ threadInfos }, await Promise.all([
messageStore,
currentUserInfo,
userInfos,
finalNavInfo,
] = await Promise.all([
threadInfoPromise, threadInfoPromise,
messageStorePromise,
currentUserInfoPromise, currentUserInfoPromise,
userInfosPromise, userInfosPromise,
initialNavInfoPromise, initialNavInfoPromise,
]); ]);
const requestedActiveChatThreadID = finalNavInfo.activeChatThreadID; const requestedActiveChatThreadID = finalNavInfo.activeChatThreadID;
if ( if (
requestedActiveChatThreadID && requestedActiveChatThreadID &&
!threadIsPending(requestedActiveChatThreadID) && !threadIsPending(requestedActiveChatThreadID) &&
!threadHasPermission( !threadHasPermission(
threadInfos[requestedActiveChatThreadID], threadInfos[requestedActiveChatThreadID],
threadPermissions.VISIBLE, threadPermissions.VISIBLE,
) )
) { ) {
finalNavInfo.activeChatThreadID = null; finalNavInfo.activeChatThreadID = null;
} }
if (!finalNavInfo.activeChatThreadID) {
const mostRecentThread = mostRecentlyReadThread(
messageStore,
threadInfos,
);
if (mostRecentThread) {
finalNavInfo.activeChatThreadID = mostRecentThread;
}
}
const curActiveChatThreadID = finalNavInfo.activeChatThreadID; const curActiveChatThreadID = finalNavInfo.activeChatThreadID;
if ( if (
curActiveChatThreadID && curActiveChatThreadID &&
threadIsPending(curActiveChatThreadID) && threadIsPending(curActiveChatThreadID) &&
finalNavInfo.pendingThread?.id !== curActiveChatThreadID finalNavInfo.pendingThread?.id !== curActiveChatThreadID
) { ) {
const pendingThreadData = parsePendingThreadID(curActiveChatThreadID); const pendingThreadData = parsePendingThreadID(curActiveChatThreadID);
if ( if (
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
threadIsPending, threadIsPending,
parsePendingThreadID, parsePendingThreadID,
createPendingThread, createPendingThread,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
▲ Show 20 Lines • Show All 214 Lines • ▼ Show 20 Lines): Promise<ServerWebInitialReduxStateResponse> {
const finalUserInfosPromise = (async () => { const finalUserInfosPromise = (async () => {
if (excludedData.userStore) { if (excludedData.userStore) {
return {}; return {};
} }
return await userInfosPromise; return await userInfosPromise;
})(); })();
const navInfoPromise = (async () => { const navInfoPromise = (async () => {
const [ const [{ threadInfos }, currentUserInfo, userInfos, finalNavInfo] =
{ threadInfos }, await Promise.all([
messageStore,
currentUserInfo,
userInfos,
finalNavInfo,
] = await Promise.all([
threadInfoPromise, threadInfoPromise,
messageStorePromise,
currentUserInfoPromise, currentUserInfoPromise,
userInfosPromise, userInfosPromise,
initialNavInfoPromise, initialNavInfoPromise,
]); ]);
const requestedActiveChatThreadID = finalNavInfo.activeChatThreadID; const requestedActiveChatThreadID = finalNavInfo.activeChatThreadID;
if ( if (
requestedActiveChatThreadID && requestedActiveChatThreadID &&
!threadIsPending(requestedActiveChatThreadID) && !threadIsPending(requestedActiveChatThreadID) &&
!threadHasPermission( !threadHasPermission(
threadInfos[requestedActiveChatThreadID], threadInfos[requestedActiveChatThreadID],
threadPermissions.VISIBLE, threadPermissions.VISIBLE,
) )
) { ) {
finalNavInfo.activeChatThreadID = null; finalNavInfo.activeChatThreadID = null;
} }
if (!finalNavInfo.activeChatThreadID) {
const mostRecentThread = mostRecentlyReadThread(
messageStore,
threadInfos,
);
if (mostRecentThread) {
finalNavInfo.activeChatThreadID = mostRecentThread;
}
}
const curActiveChatThreadID = finalNavInfo.activeChatThreadID; const curActiveChatThreadID = finalNavInfo.activeChatThreadID;
if ( if (
curActiveChatThreadID && curActiveChatThreadID &&
threadIsPending(curActiveChatThreadID) && threadIsPending(curActiveChatThreadID) &&
finalNavInfo.pendingThread?.id !== curActiveChatThreadID finalNavInfo.pendingThread?.id !== curActiveChatThreadID
) { ) {
const pendingThreadData = parsePendingThreadID(curActiveChatThreadID); const pendingThreadData = parsePendingThreadID(curActiveChatThreadID);
if ( if (
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines