we will use this cache to fetch farcaster channel image URLs (and later, descriptions)
this is modeled after the fc cache for users
Details
Details
- Reviewers
ashoat - Commits
- rCOMM91e5b576dc79: [lib] add new cache for fc channel info
tested at end of stack, made sure that we're only calling neynar API once per channel ID
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/fc-cache.js | ||
|---|---|---|
| 183 ↗ | (On Diff #45250) | You're diverging from the approach of getFarcasterUsersForFIDs, perhaps intentionally. But if you are returning in the case of a timeout, then the ternary expression on line 186 doesn't make sense. If you want to cache failed query results (eg. as a result of a timeout) then I think you'll need to change this line. If you don't want to cache them, then I think you can just use cacheTimeout in all cases. |