Page MenuHomePhabricator

[native] Fix Babel preset patch after React Native 0.70.15 upgrade
ClosedPublic

Authored by ashoat on Oct 17 2024, 12:50 PM.
Tags
None
Referenced Files
F3520947: D13748.diff
Mon, Dec 23, 1:46 AM
F3520212: D13748.id45271.diff
Sun, Dec 22, 11:36 PM
F3520211: D13748.id45270.diff
Sun, Dec 22, 11:36 PM
F3520198: D13748.id.diff
Sun, Dec 22, 11:35 PM
F3520191: D13748.diff
Sun, Dec 22, 11:35 PM
Unknown Object (File)
Sat, Dec 21, 2:32 PM
Unknown Object (File)
Thu, Dec 19, 8:06 PM
Unknown Object (File)
Thu, Dec 19, 6:17 PM
Subscribers

Details

Summary

This addresses ENG-9678, which tracks a regression caused by D13700.

Before that diff, we had just one version of metro-react-native-babel-transformer shared by Expo and React Native. After the diff, we have two versions:

  • The old metro-react-native-babel-transformer@0.72.3, used by Expo, and patched here.
  • The new metro-react-native-babel-transformer@0.72.4. It's in two places: as a transitive dependency of metro and a transitive dependency of metro-react-native-babel-transformer.

Because we now have two versions, the old patch only applies to one version, and the issue addressed by the patch was reintroduced.

I did some testing and found that of the three locations, we need two of them for the issue to be addressed: the old location, and one of the new locations, which is patched here. For some reason, the transitive dependency of metro itself does not appear to need to be patched.

Test Plan

I compiled release builds to my iOS simulator and physical Android device. I logged in as my "ashoat" user to production and confirmed I was able to resolve both normal "onchain" ENS names like "ashoat.eth" as well as "offchain" ENS names like "ashoat.base.eth".

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable