Page MenuHomePhabricator
Differential D13752

[web] update EditThreadAvatarMenu to add farcaster option
ClosedPublic
Actions

Authored by varun on Sat, Oct 19, 11:25 AM.
Tags
None
Referenced Files
F3048848: D13752.diff
Wed, Oct 23, 1:14 AM
F3041555: D13752.id.diff
Tue, Oct 22, 12:53 PM
F3039139: D13752.diff
Tue, Oct 22, 9:28 AM
F3036407: D13752.id45282.diff
Tue, Oct 22, 5:32 AM
Unknown Object (File)
Mon, Oct 21, 2:43 AM
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM0f9633f9bd67: [web] update EditThreadAvatarMenu to add farcaster option
Summary

this lets a user set a farcaster thread avatar if the thread belongs to a community tagged with a farcaster channel

Depends on D13749

Test Plan

successfully set a farcaster avatar in community root thread and child threads. was able to unset the avatar as well.

menu icon looks the same as in the user avatar menu

Diff Detail

Repository
rCOMM Comm
Branch
farcaster-thread-avatars (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sat, Oct 19, 11:25 AM
Herald added a subscriber: tomek. · View Herald TranscriptSat, Oct 19, 11:25 AM
Harbormaster completed remote builds in B32308: Diff 45282.Sat, Oct 19, 11:43 AM
varun requested review of this revision.Sat, Oct 19, 11:43 AM
varun added a child revision: D13753: [native] let user select farcaster thread avatar.Sat, Oct 19, 12:30 PM
varun added inline comments.Sat, Oct 19, 12:32 PM
web/avatars/edit-thread-avatar-menu.react.js
143

one thing worth noting is that we'll display this menu item even if the thread has inherited a farcaster avatar from its parent as the default

ashoat accepted this revision.Sun, Oct 20, 11:44 AM
This revision is now accepted and ready to land.Sun, Oct 20, 11:44 AM
Closed by commit rCOMM0f9633f9bd67: [web] update EditThreadAvatarMenu to add farcaster option (authored by varun). · Explain WhyTue, Oct 22, 9:52 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0f9633f9bd67: [web] update EditThreadAvatarMenu to add farcaster option.

Revision Contents
Changeset List

PathSize
web/
avatars/
46 lines

Diff 45282

View Options

web/avatars/edit-thread-avatar-menu.react.js

Loading...