[lib] Fix creating thick threads on added members robotext
ClosedPublic
Actions

Authored by angelika on Oct 21 2024, 6:43 AM.

Details

Reviewers

kamil
tomek
ashoat

Commits

rCOMMcf0ac2636b4d: [lib] Fix creating thick threads on added members robotext

Summary

This diff fixes creating thick threads on added members robotext by assigning the same message id to the two types of messages sent to users.

https://linear.app/comm/issue/ENG-9574/creating-thick-threads-on-robotexts-is-not-working

Test Plan

User A creates a local dm
User A adds user B
User A creates a thread on "you added user B" robotext
Verify that user B sees the thread

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Oct 21 2024, 6:43 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 21 2024, 6:43 AM

angelika added reviewers: kamil, ashoat.Oct 21 2024, 6:44 AM

Harbormaster completed remote builds in B32316: Diff 45297.Oct 21 2024, 7:02 AM

angelika requested review of this revision.Oct 21 2024, 7:02 AM

angelika edited reviewers, added: tomek; removed: ashoat.Oct 21 2024, 7:12 AM

ashoat accepted this revision.Oct 21 2024, 9:06 AM

This revision is now accepted and ready to land.Oct 21 2024, 9:06 AM

Closed by commit rCOMMcf0ac2636b4d: [lib] Fix creating thick threads on added members robotext (authored by angelika). · Explain WhyOct 21 2024, 1:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMcf0ac2636b4d: [lib] Fix creating thick threads on added members robotext.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-utils.js

6 lines

Diff 45304

View Options

lib/shared/dm-ops/dm-op-utils.js

[lib] Fix creating thick threads on added members robotextClosedPublicActions