[lib] Use getMessageForException instead of e.message in DM related code
AcceptedPublic
Actions

Authored by angelika on Mon, Oct 21, 1:28 PM.

Details

Reviewers

kamil
tomek
ashoat

Summary

Use getMessageForException instead of e.message in DM related code in order to avoid bugs when throwing primitives.
Depends on D13757

Test Plan

Run flow checks, run the app, verify that nothing crashes.

Diff Detail

Repository

rCOMM Comm

Branch

graszka22/ENG-9729

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Mon, Oct 21, 1:28 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Oct 21, 1:28 PM

angelika added reviewers: kamil, tomek.Mon, Oct 21, 1:28 PM

Harbormaster completed remote builds in B32320: Diff 45303.Mon, Oct 21, 1:58 PM

angelika requested review of this revision.Mon, Oct 21, 1:58 PM

ashoat accepted this revision.Mon, Oct 21, 2:06 PM

This revision is now accepted and ready to land.Mon, Oct 21, 2:06 PM

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-message-handler.js

10 lines

use-peer-to-peer-message-handler.js

20 lines

utils/

peer-to-peer-communication-utils.js

9 lines

Diff 45303

View Options

lib/tunnelbroker/peer-to-peer-message-handler.js

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

View Options

lib/utils/peer-to-peer-communication-utils.js

[lib] Use getMessageForException instead of e.message in DM related codeAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45303

lib/tunnelbroker/peer-to-peer-message-handler.js

lib/tunnelbroker/use-peer-to-peer-message-handler.js

lib/utils/peer-to-peer-communication-utils.js

[lib] Use getMessageForException instead of e.message in DM related code
AcceptedPublic
Actions

Revision Contents
Changeset List