Differential D13777

[lib] Fix basename test case
ClosedPublic
Actions

Authored by ashoat on Oct 23 2024, 10:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 3, 10:56 PM

	Unknown Object (File)
	Wed, Apr 2, 9:01 AM

	Unknown Object (File)
	Wed, Apr 2, 7:19 AM

	Unknown Object (File)
	Wed, Apr 2, 4:41 AM

	Unknown Object (File)
	Tue, Apr 1, 8:09 AM

	Unknown Object (File)
	Feb 28 2025, 3:02 PM

	Unknown Object (File)
	Feb 28 2025, 3:02 PM

	Unknown Object (File)
	Feb 16 2025, 12:38 PM

View All 48 Files

Subscribers

Details

Reviewers

varun
will

Commits

rCOMM7265fc4dcdfc: [lib] Fix basename test case

Summary

This addresses ENG-9757.

Test Plan

Unit test passes

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 23 2024, 10:35 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 10:35 AM

Harbormaster completed remote builds in B32348: Diff 45350.Oct 23 2024, 10:53 AM

ashoat requested review of this revision.Oct 23 2024, 10:53 AM

varun accepted this revision.Oct 23 2024, 11:06 AM

This revision is now accepted and ready to land.Oct 23 2024, 11:06 AM

Closed by commit rCOMM7265fc4dcdfc: [lib] Fix basename test case (authored by ashoat). · Explain WhyOct 23 2024, 11:34 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7265fc4dcdfc: [lib] Fix basename test case.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.test.js

20 lines

Diff 45355

lib/utils/ens-cache.test.js

	Show All 33 Lines
	function useCreateDesktopPushSubscription() {			function useCreateDesktopPushSubscription() {
	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const callSetDeviceToken = useSetDeviceTokenFanout();			const callSetDeviceToken = useSetDeviceTokenFanout();
	const staffCanSee = useStaffCanSee();			const staffCanSee = useStaffCanSee();

	React.useEffect(			React.useEffect(
	() =>			() =>
	electron?.onDeviceTokenRegistered?.((token: ?string) => {			electron?.onDeviceTokenRegistered?.((token: ?string) => {
	dispatchActionPromise(			void dispatchActionPromise(
	setDeviceTokenActionTypes,			setDeviceTokenActionTypes,
	callSetDeviceToken(token),			callSetDeviceToken(token),
	);			);
	}),			}),
	[callSetDeviceToken, dispatchActionPromise],			[callSetDeviceToken, dispatchActionPromise],
	);			);

	React.useEffect(() => {			React.useEffect(() => {
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines