Page MenuHomePhabricator
Differential D13779

reset avatar when deleteFarcasterChannelTag is called
ClosedPublic
Actions

Authored by varun on Oct 23 2024, 10:50 AM.
Tags
None
Referenced Files
F3359500: D13779.diff
Sun, Nov 24, 9:29 AM
Unknown Object (File)
Sat, Nov 23, 6:07 AM
Unknown Object (File)
Sat, Nov 23, 3:28 AM
Unknown Object (File)
Mon, Nov 18, 3:56 PM
Unknown Object (File)
Mon, Nov 18, 8:41 AM
Unknown Object (File)
Sun, Nov 10, 12:42 PM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Fri, Nov 8, 11:43 PM
View All 60 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM5ca379f72a5c: reset avatar when deleteFarcasterChannelTag is called
Summary

if a tagged community has a farcaster avatar, we should reset it to NULL when the tag is removed

Depends on D13778

Test Plan

Tested in conjunction with previous diff

idnameavatardescription

Created community

84426Oct23NULLNULL

Tagged community with spam channel. NULL description was replaced with description from neynar. (also confirmed that avatar and description were updated on client)

84426Oct23{"type":"farcaster"}Dedicated channel for everything $SPAM

Removed tag. avatar was reset to NULL. description remained

84426Oct23NULLDedicated channel for everything $SPAM

Removed description from native app. It was set to an empty string

84426Oct23NULL

Added a new description from app.

84426Oct23NULLAsdf

Tagged community with a different channel. Avatar changed but description remained the same.

84426Oct23{"type":"farcaster"}Asdf

Removed tag

84426Oct23NULLAsdf

Removed description

84426Oct23NULL

Tagged community with a different channel. empty string description was replaced with description from neynar

84426Oct23{"type":"farcaster"}your musings, thoughts & dreams; welcome here

Removed tag and set a custom emoji avatar

84426Oct23{"type":"emoji","emoji":"?","color":"57697f"}your musings, thoughts & dreams; welcome here

Added and removed a new tag, avatar was not overwritten

84426Oct23{"type":"emoji","emoji":"?","color":"57697f"}your musings, thoughts & dreams; welcome here

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 23 2024, 10:50 AM
Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 10:50 AM
varun edited the test plan for this revision. (Show Details)Oct 23 2024, 10:55 AM
varun published this revision for review.Oct 23 2024, 11:00 AM

planning changes to rethink this a little

varun planned changes to this revision.Oct 23 2024, 11:00 AM
Harbormaster completed remote builds in B32350: Diff 45352.Oct 23 2024, 12:52 PM
varun updated this revision to Diff 45358.Oct 23 2024, 7:01 PM

use updateThread in the background

varun updated this revision to Diff 45360.Oct 23 2024, 7:09 PM

fix spacing

varun updated this revision to Diff 45361.Oct 23 2024, 7:10 PM

undo last change

ashoat requested changes to this revision.Oct 23 2024, 7:10 PM
ashoat added inline comments.
keyserver/src/deleters/farcaster-channel-tag-deleters.js
74 ↗(On Diff #45360)

Unsafe if we can't find the community

79 ↗(On Diff #45360)

Result should be returned to clients and reduced

This revision now requires changes to proceed.Oct 23 2024, 7:10 PM
Harbormaster completed remote builds in B32353: Diff 45358.Oct 23 2024, 7:20 PM
Harbormaster completed remote builds in B32355: Diff 45360.Oct 23 2024, 7:35 PM
Harbormaster completed remote builds in B32356: Diff 45361.Oct 23 2024, 7:43 PM
varun updated this revision to Diff 45380.Oct 24 2024, 12:32 PM

address feedback

varun added a child revision: D13788: [lib] reduce thread updates from createOrUpdateFarcasterChannelTag and deleteFarcasterChannelTag.Oct 24 2024, 12:37 PM
Harbormaster completed remote builds in B32369: Diff 45380.Oct 24 2024, 12:51 PM
ashoat accepted this revision.Oct 24 2024, 2:47 PM
ashoat added inline comments.
keyserver/src/deleters/farcaster-channel-tag-deleters.js
100 ↗(On Diff #45380)

Why do we need to do this spread?

lib/types/community-types.js
79–82 ↗(On Diff #45380)

Isn't this only used on the client? Given we currently update keyserver before client, seems like it'll always be set

lib/types/validators/farcaster-channel-tag-validators.js
33–34 ↗(On Diff #45380)

Isn't this only used on the client? Given we currently update keyserver before client, seems like it'll always be set

This revision is now accepted and ready to land.Oct 24 2024, 2:47 PM
Closed by commit rCOMM5ca379f72a5c: reset avatar when deleteFarcasterChannelTag is called (authored by varun). · Explain WhyFri, Oct 25, 11:48 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM5ca379f72a5c: reset avatar when deleteFarcasterChannelTag is called.
varun added inline comments.Fri, Oct 25, 11:52 AM
lib/types/community-types.js
79–82 ↗(On Diff #45380)

same explanation as https://phab.comm.dev/D13778#inline-77986

lib/types/validators/farcaster-channel-tag-validators.js
33–34 ↗(On Diff #45380)

same explanation as https://phab.comm.dev/D13778#inline-77986

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
6 lines

Diff 45352

View Options

keyserver/src/deleters/farcaster-channel-tag-deleters.js

Loading...