This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.

In D13793#385651, @tomek wrote:

This implementation has a performance consequence - in the original implementation, we were only stringifying when an alert was shown. Now we're stringifying the object even for users who will never see an alert. We could consider keeping the JSON.stringify inside showAlertToStaff, but I'm not sure if it is really that important.

I would guess this perf impact is minimal

var startTime = performance.now()

for(var i = 0; i < 1000; ++i) {
JSON.stringify({"asdfasdf": "fhsdjfhsjdhf", "fjksdfhksdhfj": 234234})
}
var endTime = performance.now()

console.log(`Call to doSomething took ${endTime - startTime} milliseconds`)
VM529:8 Call to doSomething took 0.5 milliseconds

I guess we can live with it ;) I'm landing this.