[lib] Move usePersistedStateLoaded() to lib package
ClosedPublic
Actions

Authored by angelika on Mon, Oct 28, 2:44 PM.

Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMMe2ed1f3642f5: [lib] Move usePersistedStateLoaded() to lib package

Summary

Web and native use similar mechanism for checking when state is read.
This diff unifies it and moves to lib package in order to use it later in PeerToPeerMessageHandler.

Test Plan

Run the app and web and make sure the app loads.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Mon, Oct 28, 2:44 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Oct 28, 2:44 PM

angelika added a child revision: D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.Mon, Oct 28, 2:48 PM

Add file

Harbormaster failed remote builds in B32392: Diff 45414!Mon, Oct 28, 2:57 PM

Harbormaster completed remote builds in B32394: Diff 45416.Mon, Oct 28, 3:10 PM

angelika requested review of this revision.Mon, Oct 28, 3:10 PM

I think it would've been easier to review this one if you had broken it down further: one diff that renames storeLoaded to initialStateLoaded on native, and another that does the rest

This revision is now accepted and ready to land.Tue, Oct 29, 4:36 AM

Rebase

angelika added a child revision: D13814: [lib] Add `canProcess` parameter to `useActionsQueue`.Tue, Oct 29, 7:00 PM

Harbormaster completed remote builds in B32419: Diff 45446.Tue, Oct 29, 7:13 PM

angelika removed a child revision: D13802: [lib] Make sure PeerToPeerMessageHandler is run after persisted state is read.Wed, Oct 30, 5:04 AM

Closed by commit rCOMMe2ed1f3642f5: [lib] Move usePersistedStateLoaded() to lib package (authored by angelika). · Explain WhyWed, Oct 30, 6:30 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMe2ed1f3642f5: [lib] Move usePersistedStateLoaded() to lib package.