Page MenuHomePhabricator

[native] Measure whole KeyserverSelectionBottomSheet
ClosedPublic

Authored by ashoat on Mon, Nov 4, 1:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 3:21 PM
Unknown Object (File)
Wed, Nov 20, 1:13 AM
Unknown Object (File)
Tue, Nov 19, 8:59 PM
Unknown Object (File)
Sat, Nov 16, 2:51 PM
Unknown Object (File)
Sat, Nov 16, 2:34 PM
Unknown Object (File)
Fri, Nov 15, 4:18 AM
Unknown Object (File)
Thu, Nov 14, 9:54 PM
Unknown Object (File)
Thu, Nov 14, 3:14 PM
Subscribers

Details

Summary

Instead of measuring just part of this, and adding up some hardcoded constants to the measured part, we can simply measure the whole thing.

In combination with the parent diff, this allows us to remove the hardcoded constants entirely, and rely purely on the measurement.

Depends on D13867

Test Plan

In combination with the rest of the stack, I tested each individual use of our BottomSheet component to make sure that the bottom padding was reasonable. In most cases it was unchanged; in other cases, it was changed to be more consistent with the other BottomSheets in our codebase. In all cases, there was enough padding for the "home pill" at the bottom of the screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage