Page MenuHomePhabricator
Differential D13898

[web] Implement getInboundP2PMessagesByID query on worker
ClosedPublic
Actions

Authored by angelika on Fri, Nov 8, 7:52 AM.
Tags
None
Referenced Files
F3327827: D13898.diff
Wed, Nov 20, 12:35 PM
F3325324: D13898.id45741.diff
Wed, Nov 20, 6:21 AM
Unknown Object (File)
Tue, Nov 19, 1:01 AM
Unknown Object (File)
Sun, Nov 17, 9:46 PM
Unknown Object (File)
Sun, Nov 17, 9:45 PM
Unknown Object (File)
Sun, Nov 17, 4:43 PM
Unknown Object (File)
Sun, Nov 17, 8:43 AM
Unknown Object (File)
Sat, Nov 16, 9:44 PM
View All 27 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM56ed820efec3: [web] Implement getInboundP2PMessagesByID query on worker
Summary

https://linear.app/comm/issue/ENG-9713/mitigate-risk-of-olm-already-decrypted-or-keys-skipped

Depends on D13897

Test Plan

Test plan in the last diff in stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Fri, Nov 8, 7:52 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 8, 7:52 AM
angelika added a child revision: D13899: [native] Implement getInboundP2PMessagesByID query in JSI.Fri, Nov 8, 7:55 AM
Harbormaster completed remote builds in B32593: Diff 45722.Fri, Nov 8, 8:16 AM
angelika requested review of this revision.Fri, Nov 8, 8:16 AM
kamil accepted this revision.Tue, Nov 12, 2:47 AM
kamil added inline comments.
web/types/worker-types.js
276 ↗(On Diff #45722)

note for myself (and other reviewers) - there is no need to add response type because we can reuse this type, that's why Flow is not complaining

This revision is now accepted and ready to land.Tue, Nov 12, 2:47 AM
angelika updated this revision to Diff 45736.Tue, Nov 12, 4:50 AM

Rebase

Harbormaster failed remote builds in B32602: Diff 45736!Tue, Nov 12, 5:18 AM
angelika updated this revision to Diff 45741.Tue, Nov 12, 5:44 AM

Rebase

Harbormaster completed remote builds in B32607: Diff 45741.Tue, Nov 12, 6:18 AM
Closed by commit rCOMM56ed820efec3: [web] Implement getInboundP2PMessagesByID query on worker (authored by angelika). · Explain WhyWed, Nov 13, 4:17 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM56ed820efec3: [web] Implement getInboundP2PMessagesByID query on worker.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
9 lines
types/
9 lines

Diff 45784

View Options

web/shared-worker/worker/shared-worker.js

Loading...
View Options

web/types/worker-types.js

Loading...