Page MenuHomePhabricator
Differential D13917

[native] make the list of NUX tips to be displayed configurable
ClosedPublic
Actions

Authored by varun on Nov 12 2024, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 3:01 AM
Unknown Object (File)
Fri, Mar 14, 8:16 AM
Unknown Object (File)
Tue, Mar 4, 10:26 PM
Unknown Object (File)
Feb 27 2025, 5:48 AM
Unknown Object (File)
Feb 22 2025, 8:27 PM
Unknown Object (File)
Feb 22 2025, 8:27 PM
Unknown Object (File)
Feb 22 2025, 8:27 PM
Unknown Object (File)
Feb 22 2025, 8:26 PM
View All 54 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable
Summary

i'll be introducing a new tip that i want to display from the NUX tips overlay, separate from the tips that display on fist launch.

in order to do this, i need to be able to navigate to my new tip directly from the backdrop, as opposed to going through the 4 existing tips first.

in this diff, i remove nextTip from NUXTipParams. instead, in the NUX handler, we initialize an ordered list of tips and use this list to determine the next tip to display

https://linear.app/comm/issue/ENG-9913/make-the-list-of-nux-tips-to-be-displayed-configurable

Test Plan

on a fresh install, confirmed that the same 4 tips appeared as before, and that navigating through them was unchanged

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 12 2024, 12:45 PM
varun edited the summary of this revision. (Show Details)Nov 12 2024, 1:05 PM
Harbormaster completed remote builds in B32628: Diff 45764.Nov 12 2024, 1:47 PM
varun requested review of this revision.Nov 12 2024, 1:47 PM
varun added a child revision: D13920: [native] remove exitingCallback.Nov 12 2024, 1:51 PM
ashoat accepted this revision.Nov 12 2024, 2:01 PM
ashoat added 1 blocking reviewer(s): tomek.

Looks good to me! I'm not familiar with the NUX code (it was introduced while I was away) so would appreciate if @tomek could take a look too

native/components/nux-handler.react.js
24–27 ↗(On Diff #45764)

No reason to define this in the component. Can you move it to the top-level scope?

tomek accepted this revision.Nov 13 2024, 5:18 AM
This revision is now accepted and ready to land.Nov 13 2024, 5:18 AM
Closed by commit rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable (authored by varun). · Explain WhyNov 13 2024, 11:00 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable.
varun mentioned this in D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.Nov 27 2024, 11:10 AM

Revision Contents
Changeset List

PathSize
native/
components/
16 lines
5 lines
navigation/
26 lines
tooltip/
31 lines

Diff 45799

View Options

native/components/nux-handler.react.js

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines
View Options

native/components/nux-tips-context.react.js

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines
View Options

native/navigation/nux-tip-overlay-backdrop.react.js

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines
View Options

native/tooltip/nux-tips-overlay.react.js

Show All 17 Linesimport {
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems, getAllInitialSidebarItems,
getAllFinalSidebarItems, getCandidateSidebarItemsForThreadList,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines threadInfo => {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
}; };
const getFinalChatThreadItem = async () => { const getFinalChatThreadItem = async () => {
const lastUpdatedTimePromise = lastUpdatedTime(); const lastUpdatedTimePromise = lastUpdatedTime();
const candidateSidebarItemsPromise =
getCandidateSidebarItemsForThreadList(sidebars);
const lastUpdatedTimeIncludingSidebarsPromise = (async () => { const lastUpdatedTimeIncludingSidebarsPromise = (async () => {
const lastUpdatedTimePromises = [ const candidateSidebarItems = await candidateSidebarItemsPromise;
lastUpdatedTimePromise, const lastUpdatedTimes = candidateSidebarItems.map(
...sidebars.map(sidebar => sidebar.lastUpdatedTime()), sidebarItem => sidebarItem.lastUpdatedTime,
]; );
const lastUpdatedTimes = await Promise.all(lastUpdatedTimePromises);
const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1); const max = lastUpdatedTimes.reduce((a, b) => Math.max(a, b), -1);
return max; return max;
})(); })();
const [ const [
lastUpdatedTimeResult, lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars,
allSidebarItems, candidateSidebarItems,
] = await Promise.all([ ] = await Promise.all([
lastUpdatedTimePromise, lastUpdatedTimePromise,
lastUpdatedTimeIncludingSidebarsPromise, lastUpdatedTimeIncludingSidebarsPromise,
getAllFinalSidebarItems(sidebars), candidateSidebarItemsPromise,
]); ]);
return { return {
...chatThreadItemBase, ...chatThreadItemBase,
sidebars: getSidebarItems(allSidebarItems), sidebars: getSidebarItems(candidateSidebarItems),
lastUpdatedTime: lastUpdatedTimeResult, lastUpdatedTime: lastUpdatedTimeResult,
lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars: lastUpdatedTimeIncludingSidebars,
}; };
}; };
const lastUpdatedAtLeastTimeIncludingSidebars = const lastUpdatedAtLeastTimeIncludingSidebars =
sidebars.length > 0 sidebars.length > 0
? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime) ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
▲ Show 20 Lines • Show All 639 Lines • Show Last 20 Lines