Page MenuHomePhabricator

[native] make the list of NUX tips to be displayed configurable
ClosedPublic

Authored by varun on Tue, Nov 12, 12:45 PM.
Tags
None
Referenced Files
F3237725: D13917.id45764.diff
Wed, Nov 13, 3:48 AM
F3237722: D13917.id.diff
Wed, Nov 13, 3:48 AM
F3237721: D13917.diff
Wed, Nov 13, 3:48 AM
Subscribers
None

Details

Summary

i'll be introducing a new tip that i want to display from the NUX tips overlay, separate from the tips that display on fist launch.

in order to do this, i need to be able to navigate to my new tip directly from the backdrop, as opposed to going through the 4 existing tips first.

in this diff, i remove nextTip from NUXTipParams. instead, in the NUX handler, we initialize an ordered list of tips and use this list to determine the next tip to display

https://linear.app/comm/issue/ENG-9913/make-the-list-of-nux-tips-to-be-displayed-configurable

Test Plan

on a fresh install, confirmed that the same 4 tips appeared as before, and that navigating through them was unchanged

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Tue, Nov 12, 1:47 PM
ashoat added 1 blocking reviewer(s): tomek.

Looks good to me! I'm not familiar with the NUX code (it was introduced while I was away) so would appreciate if @tomek could take a look too

native/components/nux-handler.react.js
24–27 ↗(On Diff #45764)

No reason to define this in the component. Can you move it to the top-level scope?

This revision is now accepted and ready to land.Wed, Nov 13, 5:18 AM