[native] remove exitingCallback
ClosedPublic
Actions

Authored by varun on Nov 12 2024, 1:51 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM485956d0276d: [native] remove exitingCallback

Summary

we should just call navigation.goBack when we reach the end of the ordered list of tips. there's no need for the exitingCallback

Depends on D13917

Test Plan

confirmed that when i pressed ok on the final tip, i was backed out from the backdrop

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Nov 12 2024, 1:51 PM

varun added 1 blocking reviewer(s): tomek.Nov 12 2024, 2:05 PM

Harbormaster completed remote builds in B32637: Diff 45775.Nov 12 2024, 2:59 PM

varun requested review of this revision.Nov 12 2024, 2:59 PM

tomek accepted this revision.Nov 13 2024, 5:20 AM

This revision is now accepted and ready to land.Nov 13 2024, 5:20 AM

Closed by commit rCOMM485956d0276d: [native] remove exitingCallback (authored by varun). · Explain WhyNov 13 2024, 11:00 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM485956d0276d: [native] remove exitingCallback.

Revision Contents
Changeset List

Path

Size

native/

components/

nux-tips-context.react.js

5 lines

tooltip/

nux-tips-overlay.react.js

8 lines

Diff 45800

View Options

native/components/nux-tips-context.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';		import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js';		import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';		import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js';		import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';		import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';		import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';		import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';		import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
		import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js';		import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js';		import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js';		import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js';		import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js';		import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js';		import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';		import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
import InputStateContainer from './input/input-state-container.react.js';		import InputStateContainer from './input/input-state-container.react.js';
▲ Show 20 Lines • Show All 233 Lines • ▼ Show 20 Lines	navigation = (
onStateChange={onNavigationStateChange}		onStateChange={onNavigationStateChange}
theme={theme}		theme={theme}
ref={containerRef}		ref={containerRef}
>		>
<BottomSheetModalProvider>		<BottomSheetModalProvider>
<ChatContextProvider>		<ChatContextProvider>
<DeepLinksContextProvider>		<DeepLinksContextProvider>
<ChatMentionContextProvider>		<ChatMentionContextProvider>
		<NUXTipsContextProvider>
<RootNavigator />		<RootNavigator />
		</NUXTipsContextProvider>
</ChatMentionContextProvider>		</ChatMentionContextProvider>
</DeepLinksContextProvider>		</DeepLinksContextProvider>
</ChatContextProvider>		</ChatContextProvider>
<NavigationHandler />		<NavigationHandler />
<PersistedStateGate>		<PersistedStateGate>
<FarcasterDataHandler>		<FarcasterDataHandler>
<ConnectFarcasterAlertHandler />		<ConnectFarcasterAlertHandler />
</FarcasterDataHandler>		</FarcasterDataHandler>
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines