[native] remove exitingCallback
ClosedPublic
Actions

Authored by varun on Nov 12 2024, 1:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 11:05 PM

	Unknown Object (File)
	Mon, Dec 16, 2:24 PM

	Unknown Object (File)
	Sun, Dec 15, 9:06 PM

	Unknown Object (File)
	Sun, Dec 15, 4:32 PM

	Unknown Object (File)
	Sat, Dec 14, 10:49 PM

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 11:15 PM

View All 32 Files

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMM485956d0276d: [native] remove exitingCallback

Summary

we should just call navigation.goBack when we reach the end of the ordered list of tips. there's no need for the exitingCallback

Depends on D13917

Test Plan

confirmed that when i pressed ok on the final tip, i was backed out from the backdrop

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Nov 12 2024, 1:51 PM

varun added 1 blocking reviewer(s): tomek.Nov 12 2024, 2:05 PM

Harbormaster completed remote builds in B32637: Diff 45775.Nov 12 2024, 2:59 PM

varun requested review of this revision.Nov 12 2024, 2:59 PM

tomek accepted this revision.Nov 13 2024, 5:20 AM

This revision is now accepted and ready to land.Nov 13 2024, 5:20 AM

Closed by commit rCOMM485956d0276d: [native] remove exitingCallback (authored by varun). · Explain WhyNov 13 2024, 11:00 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM485956d0276d: [native] remove exitingCallback.

Revision Contents
Changeset List

Path

Size

native/

components/

nux-tips-context.react.js

5 lines

tooltip/

nux-tips-overlay.react.js

8 lines

Diff 45800

View Options

native/components/nux-tips-context.react.js