[lib] Don't swallow errors in getUserIdentities() call
Needs ReviewPublic
Actions

Authored by angelika on Thu, Nov 14, 12:51 PM.

Details

Reviewers

tomek
kamil

Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Depends on D13939

Test Plan

Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
Mobile user goes to profile -> Friend list and adds the web user as a friend
Before a thin thread was created. Now mobile user sees an alert, because there is no auxUserInfo, no thick thread and call to identity server fails.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Thu, Nov 14, 12:51 PM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Nov 14, 12:51 PM

This is a scary change... it affects all callers of useFindUserIdentities:

FarcasterDataHandler
UserInfosHandler
useSendDMOperationUtils
useThreadListSearch via useUsersSupportThickThreads
useUserProfileThreadInfo via useUsersSupportThickThreads
Thread composer code (ConnectedMessageListContainer on native, ChatThreadComposer on web) via useUsersSupportThickThreads
useThreadInfoForPossiblyPendingThread on web via useUsersSupportThickThreads
useUpdateRelationships (after D13938, via useUsersSupportThickThreads)

Is this really safe for all of those callers?

I'm also a bit confused as to why this is necessary or what it accomplishes. I re-read through the Linear task but couldn't find anything. Could you explain why we want to stop swallowing errors here?

Harbormaster completed remote builds in B32672: Diff 45831.Thu, Nov 14, 2:08 PM

angelika requested review of this revision.Thu, Nov 14, 2:08 PM

Revision Contents
Changeset List

Path

Size

lib/

components/

user-identity-cache.react.js

13 lines

Diff 45831

View Options

lib/components/user-identity-cache.react.js

[lib] Don't swallow errors in getUserIdentities() callNeeds ReviewPublicActions