[lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads()
ClosedPublic
Actions

Authored by angelika on Nov 22 2024, 1:17 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM470bb6f686d1: [lib] Check if device list exists instead of using userHasDeviceList() in…

Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Related discussion: https://phab.comm.dev/D13939#389720

Depends on D13938

Test Plan

Send and accept a friend request. Verify that a thick thread is created.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Nov 22 2024, 1:17 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 22 2024, 1:17 PM

angelika added a child revision: D14023: [lib] Don't created thin thread if call to identity server failed when adding friends.Nov 22 2024, 1:23 PM

angelika mentioned this in D13939: [lib] Consider thread infos in useUsersSupportThickThreads().Nov 22 2024, 1:24 PM

Harbormaster completed remote builds in B32787: Diff 45974.Nov 22 2024, 1:33 PM

angelika requested review of this revision.Nov 22 2024, 1:33 PM

kamil accepted this revision.Nov 25 2024, 5:11 AM

This revision is now accepted and ready to land.Nov 25 2024, 5:11 AM

Rebase

Harbormaster completed remote builds in B33056: Diff 46374.Dec 12 2024, 5:03 AM

Closed by commit rCOMM470bb6f686d1: [lib] Check if device list exists instead of using userHasDeviceList() in… (authored by angelika). · Explain WhyDec 12 2024, 5:23 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM470bb6f686d1: [lib] Check if device list exists instead of using userHasDeviceList() in….

Revision Contents
Changeset List

Path

Size

lib/

hooks/

user-identities-hooks.js

3 lines

Diff 45974

View Options

lib/hooks/user-identities-hooks.js

[lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads()ClosedPublicActions