Page MenuHomePhabricator

[lib] Don't created thin thread if call to identity server failed when adding friends
Needs ReviewPublic

Authored by angelika on Fri, Nov 22, 1:23 PM.
Tags
None
Referenced Files
F3348794: D14023.id45975.diff
Fri, Nov 22, 4:07 PM
F3348786: D14023.id.diff
Fri, Nov 22, 4:07 PM
F3348784: D14023.diff
Fri, Nov 22, 4:07 PM
Subscribers

Details

Reviewers
kamil
tomek
Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Related discussion: https://phab.comm.dev/D13940#389316
Now we're throwing an error just in useUpdateRelationships(), there are no changes in getUserIdentities()
and useUsersSupportThickThreads() returns Map instead of Set

Depends on D14022

Test Plan

Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
Mobile user goes to profile -> Friend list and adds the web user as a friend
Before a thin thread was created. Now mobile user sees an alert, because there is no auxUserInfo, no thick thread and call to identity server fails.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage