Page MenuHomePhabricator
Differential D14078

[native] Memoize logOutOptions
ClosedPublic
Actions

Authored by bartek on Dec 4 2024, 7:44 AM.
Tags
None
Referenced Files
F3736939: D14078.id46212.diff
Thu, Jan 9, 7:03 AM
F3736435: D14078.diff
Thu, Jan 9, 6:10 AM
Unknown Object (File)
Wed, Jan 8, 5:29 AM
Unknown Object (File)
Sun, Jan 5, 1:59 AM
Unknown Object (File)
Thu, Jan 2, 6:38 PM
Unknown Object (File)
Wed, Jan 1, 2:46 PM
Unknown Object (File)
Wed, Jan 1, 2:46 PM
Unknown Object (File)
Wed, Jan 1, 2:46 PM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
ashoat
Commits
rCOMM58cdeac3bb64: [native] Memoize logOutOptions
Summary

In https://phab.comm.dev/D14036?id=45997 I addressed one comment but missed another.

Test Plan

Flow, lint

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 4 2024, 7:44 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 4 2024, 7:44 AM
Harbormaster completed remote builds in B32926: Diff 46210.Dec 4 2024, 8:01 AM
bartek published this revision for review.Dec 4 2024, 8:09 AM
ashoat accepted this revision.Dec 4 2024, 8:54 AM
This revision is now accepted and ready to land.Dec 4 2024, 8:54 AM
Closed by commit rCOMM58cdeac3bb64: [native] Memoize logOutOptions (authored by bartek). · Explain WhyDec 6 2024, 4:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM58cdeac3bb64: [native] Memoize logOutOptions.

Revision Contents
Changeset List

PathSize
native/
profile/
10 lines

Diff 46236

View Options

native/profile/profile-screen.react.js

Loading...