[keyserver][script] get IDs for community names
ClosedPublic
Actions

Authored by varun on Wed, Dec 11, 9:23 PM.

Details

Reviewers

Commits

rCOMM459ec0313932: [keyserver][script] get IDs for community names

Summary

we want to harcode a list of crypto community IDs so that we can display the associated communities in a tab for crypto users. i have a list of crypto community names, and need to turn this into a list of IDs

https://linear.app/comm/issue/ENG-9953/get-list-of-crypto-communities-from-ashoat-and-rahul

Test Plan

ran this locally with a couple community names and got back the corresponding IDs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Wed, Dec 11, 9:23 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Dec 11, 9:23 PM

varun mentioned this in D13996: [native] community joiner modal.Wed, Dec 11, 9:28 PM

Harbormaster completed remote builds in B33053: Diff 46371.Wed, Dec 11, 9:40 PM

varun requested review of this revision.Wed, Dec 11, 9:40 PM

varun edited the summary of this revision. (Show Details)Thu, Dec 12, 7:56 AM

Passing back with some questions

keyserver/src/scripts/get-community-ids.js
18 ↗	(On Diff #46371)	What happens if a given community name is used by multiple communities? I think we have at least one case of this already for "Memes" One way to disambiguate is to only look for the communities that have an associated Farcaster channel
29 ↗	(On Diff #46371)	Will you provide the list? Wondering why it's not in the file already
30 ↗	(On Diff #46371)	How do we know if we failed to fetch an ID for a given community? Do you plan to manually comb through and let me know which (if any) are missing?

This revision now requires changes to proceed.Thu, Dec 12, 11:06 AM

address feedback

keyserver/src/scripts/get-community-ids.js
29 ↗	(On Diff #46371)	Oh, I shared it in the linear issue: https://linear.app/comm/issue/ENG-9953/get-list-of-crypto-communities-from-ashoat-and-rahul#comment-2fa1b5a3 I didn't hardcode it in the script so that it can be more general purpose