[lib] Add log and continue in getPushUserInfo when thread missing from ThreadStore
ClosedPublic
Actions

Authored by ashoat on Mon, Dec 16, 6:34 AM.

Details

Reviewers

angelika
kamil
tomek

Commits

rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from…

Summary

This has come up twice now: ENG-9454 and ENG-9946.

I think it will help us in the future to have a more specific error message. It also is probably a good idea to continue; here, in case there are other notifs that we can send successfully.

Test Plan

Ran the code and confirmed the log was printed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Dec 16, 6:34 AM

Harbormaster completed remote builds in B33153: Diff 46494.Mon, Dec 16, 11:09 AM

ashoat requested review of this revision.Mon, Dec 16, 11:09 AM

kamil accepted this revision.Tue, Dec 17, 1:38 AM

This revision is now accepted and ready to land.Tue, Dec 17, 1:38 AM

Closed by commit rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from… (authored by ashoat). · Explain WhyTue, Dec 17, 8:51 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from….

Revision Contents
Changeset List

Path

Size

lib/

push/

send-utils.js

4 lines

Diff 46562

View Options

[lib] Add log and continue in getPushUserInfo when thread missing from ThreadStoreClosedPublicActions