[lib] Add log and continue in getPushUserInfo when thread missing from ThreadStore
ClosedPublic
Actions

Authored by ashoat on Dec 16 2024, 2:34 PM.

Details

Reviewers

angelika
kamil
tomek

Commits

rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from…

Summary

This has come up twice now: ENG-9454 and ENG-9946.

I think it will help us in the future to have a more specific error message. It also is probably a good idea to continue; here, in case there are other notifs that we can send successfully.

Test Plan

Ran the code and confirmed the log was printed

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/log

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 16 2024, 2:34 PM

Harbormaster completed remote builds in B33153: Diff 46494.Dec 16 2024, 7:09 PM

ashoat requested review of this revision.Dec 16 2024, 7:09 PM

kamil accepted this revision.Dec 17 2024, 9:38 AM

This revision is now accepted and ready to land.Dec 17 2024, 9:38 AM

Closed by commit rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from…. · Explain WhyDec 18 2024, 4:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from….

Revision Contents
Changeset List

Path

Size

lib/

push/

send-utils.js

4 lines

Diff 46494

View Options

[lib] Add log and continue in getPushUserInfo when thread missing from ThreadStoreClosedPublicActions