[identity] Support skip_password_reset in PrivilegedResetUserPassword RPC
ClosedPublic
Actions

Authored by bartek on Jan 13 2025, 6:49 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM7fde3f6bddaf: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC

Summary

Server-side implementation of ENG-9628.

Depends on D14199

Test Plan

Mocked privileged users set locally to include my user ID

When the flag is false, the PrivilegedResetUserPassword RPC behaves as before
- Password is reset
- Returns user not found for wallet users
When the flag is true
- Works for both password and wallet users
- Password is not updated
- User is still logged out of all devices - device list is reset to unsigned

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 13 2025, 6:49 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 13 2025, 6:49 AM

Harbormaster completed remote builds in B33236: Diff 46667.Jan 13 2025, 7:15 AM

bartek published this revision for review.Jan 13 2025, 7:19 AM

kamil accepted this revision.Jan 14 2025, 1:53 AM

This revision is now accepted and ready to land.Jan 14 2025, 1:53 AM

Closed by commit rCOMM7fde3f6bddaf: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC (authored by bartek). · Explain WhyJan 14 2025, 4:19 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7fde3f6bddaf: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

44 lines

token.rs

11 lines

Diff 46673

View Options

services/identity/src/grpc_services/authenticated.rs

	// @flow			// @flow

	import { memberHasAdminPowers } from './thread-utils.js';			import { memberHasAdminPowers } from './thread-utils.js';
	import bots from '../facts/bots.js';
	import staff from '../facts/staff.js';
	import { useENSNames } from '../hooks/ens-cache.js';			import { useENSNames } from '../hooks/ens-cache.js';
	import type {			import type {
	ServerThreadInfo,
	RawThreadInfo,			RawThreadInfo,
				ServerThreadInfo,
	ThreadInfo,			ThreadInfo,
	} from '../types/thread-types.js';			} from '../types/thread-types.js';
	import type { UserInfo } from '../types/user-types.js';			import type { UserInfo } from '../types/user-types.js';
	import { useSelector } from '../utils/redux-utils.js';			import { useSelector } from '../utils/redux-utils.js';

	function stringForUser(user: {			function stringForUser(user: {
	+username?: ?string,			+username?: ?string,
	+isViewer?: ?boolean,			+isViewer?: ?boolean,
	Show All 9 Lines
	function stringForUserExplicit(user: { +username: ?string, ... }): string {			function stringForUserExplicit(user: { +username: ?string, ... }): string {
	if (user.username) {			if (user.username) {
	return user.username;			return user.username;
	} else {			} else {
	return 'anonymous';			return 'anonymous';
	}			}
	}			}

	function isStaff(userID: string): boolean {
	if (staff.includes(userID)) {
	return true;
	}
	for (const key in bots) {
	const bot = bots[key];
	if (userID === bot.userID) {
	return true;
	}
	}
	return false;
	}

	function useKeyserverAdmin(			function useKeyserverAdmin(
	community: ThreadInfo \| RawThreadInfo \| ServerThreadInfo,			community: ThreadInfo \| RawThreadInfo \| ServerThreadInfo,
	): ?UserInfo {			): ?UserInfo {
	const userInfos = useSelector(state => state.userStore.userInfos);			const userInfos = useSelector(state => state.userStore.userInfos);
	// This hack only works as long as there is only one admin			// This hack only works as long as there is only one admin
	// Linear task to revert this:			// Linear task to revert this:
	// https://linear.app/comm/issue/ENG-1707/revert-fix-getting-the-keyserver-admin-info			// https://linear.app/comm/issue/ENG-1707/revert-fix-getting-the-keyserver-admin-info
	const admin = community.members.find(memberHasAdminPowers);			const admin = community.members.find(memberHasAdminPowers);
	const adminUserInfo = admin ? userInfos[admin.id] : undefined;			const adminUserInfo = admin ? userInfos[admin.id] : undefined;
	const [adminUserInfoWithENSName] = useENSNames([adminUserInfo]);			const [adminUserInfoWithENSName] = useENSNames([adminUserInfo]);
	return adminUserInfoWithENSName;			return adminUserInfoWithENSName;
	}			}

	export { stringForUser, stringForUserExplicit, isStaff, useKeyserverAdmin };			export { stringForUser, stringForUserExplicit, useKeyserverAdmin };