Differential D14201

[native] Update BackupHandler logic to avoid pruning DDB
ClosedPublic
Actions

Authored by bartek on Jan 14 2025, 1:20 PM.

Details

Reviewers

kamil

Commits

rCOMMc9327ed645b1: [native] Update BackupHandler logic to avoid pruning DDB

Summary

Address ENG-9622 comment.

Test Plan

Manually removed device list signature, kept backup. Verified that the migration was run and backup was regenerated.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 14 2025, 1:20 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 14 2025, 1:20 PM

bartek published this revision for review.Jan 14 2025, 1:24 PM

kamil accepted this revision.Jan 14 2025, 1:38 PM

kamil added inline comments.

native/backup/backup-handler.js
252	not sure if the name is accurate anymore

This revision is now accepted and ready to land.Jan 14 2025, 1:38 PM

Harbormaster completed remote builds in B33237: Diff 46674.Jan 14 2025, 1:38 PM

bartek added inline comments.Jan 14 2025, 1:40 PM

native/backup/backup-handler.js
252	I cannot think of any better name

Closed by commit rCOMMc9327ed645b1: [native] Update BackupHandler logic to avoid pruning DDB. · Explain WhyJan 14 2025, 1:52 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc9327ed645b1: [native] Update BackupHandler logic to avoid pruning DDB.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

4 lines

Diff 46674

View Options

native/backup/backup-handler.js

[native] Update BackupHandler logic to avoid pruning DDBClosedPublicActions