[native] Save the correct backup credentials
ClosedPublic
Actions

Authored by tomek on Jan 17 2025, 4:02 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM56bb03f4fad7: [native] Save the correct backup credentials

Summary

These credentials are used e.g. to create a new backup, and they should match the result returned from the SIWE panel.

https://linear.app/comm/issue/ENG-10099/sometimes-backup-restoration-cant-be-completed-due-to-a-cryptokit

Test Plan

Register a new SIWE user, log out, restore (this creates a new backup), log out, restore (this tests whether the new backup is correct). Confirm that the 2nd restoration works.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jan 17 2025, 4:02 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2025, 4:02 PM

Harbormaster completed remote builds in B33261: Diff 46705.Jan 17 2025, 4:20 PM

tomek requested review of this revision.Jan 17 2025, 4:20 PM

kamil accepted this revision.Jan 20 2025, 10:04 AM

kamil added inline comments.

native/account/restore-backup-screen.react.js
38–39	Alternatively, you can also this wrap into `SIWESocialProof` type we have already defined to improve readability more

This revision is now accepted and ready to land.Jan 20 2025, 10:04 AM

tomek added inline comments.Jan 20 2025, 12:57 PM

native/account/restore-backup-screen.react.js
38–39	Makes sense! We can make it even better by using the same type for all the message-signature pairs.

Reuse the types

tomek added inline comments.Jan 20 2025, 1:54 PM

native/account/restore-backup-screen.react.js
38–39	Using `SIWESocialProof` is a bit problematic, because it gets later directly stringified and saved in the keyserver DB, so renaming its fields isn't worth it.