Differential D14254

[Tunnelbroker] ignore errors about closed connection when sending message to device
ClosedPublic
Actions

Authored by kamil on Jan 28 2025, 10:51 AM.

Details

Reviewers

bartek

Commits

rCOMM1a8de1b7b28f: [Tunnelbroker] ignore errors about closed connection when sending message to…

Summary

This is a fix for ENG-10110.

The code here triggered an error because it kept sending messages probably before receiving close message.

Test Plan

This is complicated to reproduce so just carefully reading the code as we are using exactly the same approach as here. I am going to test it more after deploying to staging.

Diff Detail

Repository

rCOMM Comm

Branch

backup-changes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 28 2025, 10:51 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 28 2025, 10:51 AM

kamil published this revision for review.Jan 28 2025, 10:56 AM

kamil edited the summary of this revision. (Show Details)

bartek accepted this revision.Jan 28 2025, 11:00 AM

This revision is now accepted and ready to land.Jan 28 2025, 11:00 AM

Harbormaster completed remote builds in B33326: Diff 46816.Jan 28 2025, 11:09 AM

Closed by commit rCOMM1a8de1b7b28f: [Tunnelbroker] ignore errors about closed connection when sending message to…. · Explain WhyJan 28 2025, 11:18 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1a8de1b7b28f: [Tunnelbroker] ignore errors about closed connection when sending message to….

kamil mentioned this in D14274: [terraform] Bump staging Tunnelbroker to 0.18.3.Jan 29 2025, 3:58 PM

kamil mentioned this in rCOMMcb3172fbf44e: [terraform] Bump staging Tunnelbroker to 0.18.3.Jan 30 2025, 10:00 AM

kamil mentioned this in D14292: [terraform] Bump prod Tunnelbroker to 0.18.3.Feb 5 2025, 12:05 PM

kamil mentioned this in rCOMM913d2cf02608: [terraform] Bump prod Tunnelbroker to 0.18.3.Feb 5 2025, 2:22 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

websockets/

session.rs

19 lines

Diff 46816

View Options

services/tunnelbroker/src/websockets/session.rs

[Tunnelbroker] ignore errors about closed connection when sending message to deviceClosedPublicActions