Page MenuHomePhabricator
Differential D14276

[backup] Add /prepare_user_keys endpoint
ClosedPublic
Actions

Authored by bartek on Jan 30 2025, 1:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 2:07 PM
Unknown Object (File)
Wed, Feb 19, 6:17 AM
Unknown Object (File)
Tue, Feb 18, 11:25 AM
Unknown Object (File)
Tue, Feb 18, 10:43 AM
Unknown Object (File)
Mon, Feb 17, 1:34 PM
Unknown Object (File)
Mon, Feb 17, 12:15 PM
Unknown Object (File)
Mon, Feb 17, 9:26 AM
Unknown Object (File)
Sun, Feb 16, 12:10 AM
View All 38 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM305e70b8cbcf: [backup] Add /prepare_user_keys endpoint
Summary

This endpoint is very similiar to the POST /backups/user_keys with the following differences:

  • Is only callable by other services
  • User ID is passed in the form, instead of being retrieved from auth header
  • Doesn't save keys in DDB, instead returns BackupItem payload in response

Depends on D14275

Test Plan

Used Postman to call the endpoint:

  • Confirmed that user keys blob was stored in Blob Service
  • Confirmed that BackupItem payload JSON was returned in response

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jan 30 2025, 1:48 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 30 2025, 1:48 AM
bartek added a child revision: D14277: [identity] Backup client method for preparing user keys.Jan 30 2025, 1:48 AM
Harbormaster failed remote builds in B33354: Diff 46851!Jan 30 2025, 2:02 AM
bartek updated this revision to Diff 46861.Jan 30 2025, 3:06 AM

Rebase

Harbormaster completed remote builds in B33363: Diff 46861.Jan 30 2025, 3:27 AM
bartek published this revision for review.Jan 30 2025, 3:29 AM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek mentioned this in D14283: [identity] Upload UserKeys backup in RestoreUser RPC.Jan 30 2025, 3:51 AM
kamil accepted this revision.Jan 30 2025, 4:36 AM
kamil added inline comments.
services/backup/src/http/mod.rs
98–102 ↗(On Diff #46861)

I would add comment explaining purpose of this endpoint

This revision is now accepted and ready to land.Jan 30 2025, 4:36 AM
bartek updated this revision to Diff 46889.Fri, Jan 31, 6:33 AM

Add comment

Harbormaster completed remote builds in B33377: Diff 46889.Fri, Jan 31, 6:52 AM
Closed by commit rCOMM305e70b8cbcf: [backup] Add /prepare_user_keys endpoint (authored by bartek). · Explain WhySun, Feb 2, 11:28 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM305e70b8cbcf: [backup] Add /prepare_user_keys endpoint.
kamil mentioned this in rCOMM9a7a4d05e65b: [identity] Upload UserKeys backup in RestoreUser RPC.Wed, Feb 5, 3:47 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
http/
handlers/
196 lines
8 lines

Diff 46893

View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

services/backup/src/http/mod.rs

Loading...