In D14265 we made this flag true for all the staff users, but by mistake this resulted in turning this flag off for the dev users.
https://linear.app/comm/issue/ENG-10127/logging-out-on-the-web-results-in-an-error
Details
Details
- Reviewers
kamil bartek - Commits
- rCOMMc533bbe34dd6: [lib] Turn the flag on for dev
Check if the proper login layout is shown on dev.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/utils/services-utils.js | ||
|---|---|---|
| 29–32 ↗ | (On Diff #46869) | nit |
Comment Actions
Actually, one question.
I am afraid this could block staff users from logging back, given this scenario:
- I am using staff release now
- I want to test something so logging out and trying to log back
- This flag is set to false because it's not a staff user (anonymous) and not a dev, so I do not see the restore flow
- I am unable to log in because I have already migrated and Identity returns out_of_date.
Is it correct?
Comment Actions
That's a valid concern, but for the staff release, we're modifying this code https://linear.app/comm/issue/ENG-10127/logging-out-on-the-web-results-in-an-error#comment-bd9e6894 so that the flag is always true.
| lib/utils/services-utils.js | ||
|---|---|---|
| 29–32 ↗ | (On Diff #46869) | We had an interesting discussion with @kamil and agreed that the original solution is more readable. It comes from the fact that isDev is a special case that stops the logic from performing the standard stuff - a kind of early return. |
Comment Actions
That's a valid concern, but for the staff release, we're modifying this code https://linear.app/comm/issue/ENG-10127/logging-out-on-the-web-results-in-an-error#comment-bd9e6894 so that the flag is always true.
I missed that comment, makes sense now