Page MenuHomePhabricator
Differential D14303

[native] Migrate pinch gesture handling in FullScreenViewModal
ClosedPublic
Actions

Authored by angelika on Feb 6 2025, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 4:46 AM
Unknown Object (File)
Thu, Apr 3, 12:18 PM
Unknown Object (File)
Thu, Apr 3, 4:25 AM
Unknown Object (File)
Fri, Mar 14, 7:59 AM
Unknown Object (File)
Fri, Mar 14, 7:59 AM
Unknown Object (File)
Fri, Mar 14, 7:58 AM
Unknown Object (File)
Wed, Mar 12, 9:52 AM
Unknown Object (File)
Wed, Mar 12, 9:02 AM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
tomek
ashoat
Commits
rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal
Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Migrate`pinchUpdate` method which updates image scale when pinch gesture is in progress based on the delta between current and last pinch scale, just like in the original implementation.

Depends on D14302

Test Plan

Tested after migration: verify pinch gesture works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Feb 6 2025, 5:09 PM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 6 2025, 5:09 PM
angelika added a child revision: D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.Feb 6 2025, 5:11 PM
Harbormaster completed remote builds in B33418: Diff 46947.Feb 6 2025, 5:55 PM
angelika edited the summary of this revision. (Show Details)Feb 7 2025, 5:27 AM
angelika added inline comments.
native/components/full-screen-view-modal.react.js
89–101 ↗(On Diff #46947)

The math for delta calculations are taken from here

angelika updated this revision to Diff 47081.Feb 12 2025, 8:51 PM
angelika marked an inline comment as not done.

Rebase & bugfixes

angelika published this revision for review.Feb 12 2025, 9:06 PM
Harbormaster completed remote builds in B33497: Diff 47081.Feb 12 2025, 9:50 PM
ashoat accepted this revision.Feb 14 2025, 12:51 AM
ashoat added inline comments.
native/components/full-screen-view-modal.react.js
1191–1192 ↗(On Diff #47081)

Looks like updating these is handled in D14311

This revision is now accepted and ready to land.Feb 14 2025, 12:51 AM
angelika updated this revision to Diff 47185.Feb 20 2025, 2:13 PM

Rebase & bugfixes

angelika updated this revision to Diff 47219.Feb 24 2025, 3:51 AM

Rebase

Harbormaster completed remote builds in B33599: Diff 47219.Feb 24 2025, 5:18 AM
Closed by commit rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal (authored by angelika). · Explain WhyFeb 25 2025, 2:48 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal.

Revision Contents
Changeset List

PathSize
native/
components/
75 lines

Diff 47247

View Options

native/components/full-screen-view-modal.react.js

Loading...