Details

Reviewers

tomek

Commits

rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional…

Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Depends on D14310

Test Plan

Test after migration: verify the image is displayed, zoomed in/out in correct size and position

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Feb 7 2025, 1:44 AM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 7 2025, 1:44 AM

angelika added a child revision: D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.Feb 7 2025, 1:46 AM

Harbormaster completed remote builds in B33426: Diff 46955.Feb 7 2025, 3:09 AM

angelika edited the summary of this revision. (Show Details)Feb 10 2025, 9:06 AM

Rebase & bugfixes

angelika published this revision for review.Feb 13 2025, 5:11 AM

Harbormaster completed remote builds in B33505: Diff 47089.Feb 13 2025, 7:10 AM

ashoat mentioned this in D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.Feb 14 2025, 8:51 AM

tomek accepted this revision.Feb 17 2025, 12:06 PM

This revision is now accepted and ready to land.Feb 17 2025, 12:06 PM

Rebase & bugfixes

Rebase

Harbormaster failed remote builds in B33585: Diff 47205!Feb 22 2025, 4:27 AM

Fix rebase

Harbormaster completed remote builds in B33591: Diff 47211.Feb 22 2025, 7:01 AM

Rebase

This revision was landed with ongoing or failed builds.Feb 25 2025, 10:48 AM

Closed by commit rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional…. · Explain Why

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional….

[native] Migrate updateDimensions method in FullScreenViewModal to functional component
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47255

native/components/full-screen-view-modal.react.js

[native] Migrate updateDimensions method in FullScreenViewModal to functional componentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47255

native/components/full-screen-view-modal.react.js

[native] Migrate updateDimensions method in FullScreenViewModal to functional component
ClosedPublic
Actions

Revision Contents
Changeset List