Page MenuHomePhabricator
Differential D14311

[native] Migrate updateDimensions method in FullScreenViewModal to functional component
ClosedPublic
Actions

Authored by angelika on Feb 6 2025, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 10:35 PM
Unknown Object (File)
Mon, Apr 7, 9:24 PM
Unknown Object (File)
Mon, Apr 7, 8:53 PM
Unknown Object (File)
Mon, Apr 7, 2:20 PM
Unknown Object (File)
Mon, Apr 7, 10:01 AM
Unknown Object (File)
Fri, Apr 4, 10:59 PM
Unknown Object (File)
Sat, Mar 15, 5:39 PM
Unknown Object (File)
Fri, Mar 14, 7:59 AM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional…
Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Depends on D14310

Test Plan

Test after migration: verify the image is displayed, zoomed in/out in correct size and position

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Feb 6 2025, 5:44 PM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 6 2025, 5:44 PM
angelika added a child revision: D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.Feb 6 2025, 5:46 PM
Harbormaster completed remote builds in B33426: Diff 46955.Feb 6 2025, 7:09 PM
angelika edited the summary of this revision. (Show Details)Feb 10 2025, 1:06 AM
angelika updated this revision to Diff 47089.Feb 12 2025, 8:53 PM

Rebase & bugfixes

angelika published this revision for review.Feb 12 2025, 9:11 PM
Harbormaster completed remote builds in B33505: Diff 47089.Feb 12 2025, 11:10 PM
ashoat mentioned this in D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.Feb 14 2025, 12:51 AM
tomek accepted this revision.Feb 17 2025, 4:06 AM
This revision is now accepted and ready to land.Feb 17 2025, 4:06 AM
angelika updated this revision to Diff 47193.Feb 20 2025, 2:15 PM

Rebase & bugfixes

angelika updated this revision to Diff 47205.Feb 21 2025, 8:08 PM

Rebase

Harbormaster failed remote builds in B33585: Diff 47205!Feb 21 2025, 8:27 PM
angelika updated this revision to Diff 47211.Feb 21 2025, 10:14 PM

Fix rebase

Harbormaster completed remote builds in B33591: Diff 47211.Feb 21 2025, 11:01 PM
angelika updated this revision to Diff 47227.Feb 24 2025, 3:53 AM

Rebase

This revision was landed with ongoing or failed builds.Feb 25 2025, 2:48 AM
Closed by commit rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional… (authored by angelika). · Explain Why
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional….

Revision Contents
Changeset List

PathSize
native/
components/
71 lines

Diff 47255

View Options

native/components/full-screen-view-modal.react.js

locals { locals {
identity_service_image_tag = local.is_staging ? "0.51.2" : "0.51.1" identity_service_image_tag = local.is_staging ? "0.51.2" : "0.51.2"
identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}" identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
identity_service_container_name = "identity-server" identity_service_container_name = "identity-server"
# Port that the container is listening on # Port that the container is listening on
identity_service_container_grpc_port = 50054 identity_service_container_grpc_port = 50054
identity_sc_port_name = "identity-service-ecs-grpc" identity_sc_port_name = "identity-service-ecs-grpc"
identity_sc_dns_name = "identity-service" identity_sc_dns_name = "identity-service"
▲ Show 20 Lines • Show All 305 Lines • Show Last 20 Lines