[keyserver] avoid creating new `olm.Account` object in `fetchCallUpdateOlmAccount`
ClosedPublic
Actions

Authored by kamil on Feb 10 2025, 2:59 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM4090d9f602f1: [keyserver] avoid creating new `olm.Account` object in…

Summary

Fixing issue described in ENG-10144#comment-16a38c06.

Tracked in ENG-10174

Using dedicated function.

Depends on D14317

Test Plan

N/A, implementation is the same, just calling function which handles cleanup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 10 2025, 2:59 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 10 2025, 2:59 PM

kamil added a child revision: D14319: [keyserver] update `getContentSigningKey` to avoid calling `fetchOlmAccount`.Feb 10 2025, 3:09 PM

Harbormaster completed remote builds in B33434: Diff 46964.Feb 10 2025, 3:16 PM

kamil published this revision for review.Feb 10 2025, 4:22 PM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Feb 11 2025, 10:36 AM

This revision is now accepted and ready to land.Feb 11 2025, 10:36 AM

bartek accepted this revision.Feb 11 2025, 11:35 AM

Closed by commit rCOMM4090d9f602f1: [keyserver] avoid creating new `olm.Account` object in…. · Explain WhyFeb 12 2025, 4:48 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4090d9f602f1: [keyserver] avoid creating new `olm.Account` object in….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

olm-account-updater.js

24 lines

Diff 47062

View Options

keyserver/src/updaters/olm-account-updater.js

[keyserver] avoid creating new `olm.Account` object in `fetchCallUpdateOlmAccount`ClosedPublicActions