[keyserver] remove `picklingKey` from callback in `unpickleSessionAndUseCallback`
ClosedPublic
Actions

Authored by kamil on Feb 13 2025, 11:30 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMfc72e96e3bfa: [keyserver] remove `picklingKey` from callback in…

Summary

Context in https://phab.comm.dev/D14325#inline-79824

After further refactoring in turned out it can be removed.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 13 2025, 11:30 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 13 2025, 11:30 AM

kamil mentioned this in D14325: [keyserver] deprecate `unpickleOlmSession`.Feb 13 2025, 11:31 AM

kamil published this revision for review.Feb 13 2025, 11:39 AM

Harbormaster completed remote builds in B33509: Diff 47093.Feb 13 2025, 11:49 AM

kamil edited the summary of this revision. (Show Details)Feb 13 2025, 2:57 PM

tomek accepted this revision.Feb 13 2025, 4:38 PM

This revision is now accepted and ready to land.Feb 13 2025, 4:38 PM

Closed by commit rCOMMfc72e96e3bfa: [keyserver] remove `picklingKey` from callback in…. · Explain WhyFeb 14 2025, 9:35 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMfc72e96e3bfa: [keyserver] remove `picklingKey` from callback in….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

olm-objects.js

4 lines

Diff 47100

View Options

keyserver/src/utils/olm-objects.js

[keyserver] remove `picklingKey` from callback in `unpickleSessionAndUseCallback`ClosedPublicActions