Address ENG-10178 for Identity.
Details
Details
Verified during investigations on staging that these logs are now displayed.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/identity/src/client_service.rs | ||
|---|---|---|
| 722–730 ↗ | (On Diff #47110) | nit: it looks like this should be a child revision for D14367 |
| 835 ↗ | (On Diff #47110) | This shouldn't happen anymore, can we at least log it? |
| 858 ↗ | (On Diff #47110) | can we add logging also here? |
| services/identity/src/comm_service/backup.rs | ||
| 18 ↗ | (On Diff #47110) | should this be only debug? |
| services/identity/src/grpc_services/authenticated.rs | ||
| 950 ↗ | (On Diff #47110) | can we add logs also here, at least for migration but overall log should also help |
| 1256–1259 ↗ | (On Diff #47110) | I would add this logging higher, right after calling RPC/method. In this case, if e.g. get_current_devices returns an error we'll still have an issue investigating what happened. This comment applied to this entire diff |
| services/identity/src/comm_service/backup.rs | ||
|---|---|---|
| 18 ↗ | (On Diff #47110) | I was afraid that it could spam a bit too much, but after looking at my staging logs, it seems to be okay to bump it to info. |
| services/identity/src/grpc_services/authenticated.rs | ||
| 950 ↗ | (On Diff #47110) | Good idea, we can also add a log below to indicate if it's a migration call or regular update |
| 1256–1259 ↗ | (On Diff #47110) | Good call, thanks |
| services/identity/src/grpc_services/authenticated.rs | ||
|---|---|---|
| 385–388 ↗ | (On Diff #47110) | Here I deliberately left the log a little lower to also log is_new_flow_user |