[web] Extract the common logic from the QR auth
ClosedPublic
Actions

Authored by tomek on Feb 17 2025, 5:33 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM680b5f5fa416: [web] Extract the common logic from the QR auth

Summary

The same logic is used in two places, which means we can extract it. We can't simply share the logic with native, where a focusEffect is used, but this isn't a big issue because native isn't affected by the bug we're fixing.

https://linear.app/comm/issue/ENG-10200/secondary-logout-in-signed-device-list-is-not-working-on-web

Test Plan

Test if logging in using the QR code works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 17 2025, 5:33 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 17 2025, 5:33 PM

tomek retitled this revision from [web] Create an unauthenticated Tunnelbroker connection only when socket connection becomes unauthorized to [web] Extract the common logic from the QR auth.Feb 17 2025, 5:35 PM

tomek added a child revision: D14376: [web][native] Create an unauthenticated Tunnelbroker connection only when socket connection becomes unauthorized.Feb 17 2025, 5:44 PM

Harbormaster completed remote builds in B33530: Diff 47130.Feb 17 2025, 5:52 PM

tomek requested review of this revision.Feb 17 2025, 5:52 PM

kamil accepted this revision.Feb 18 2025, 11:30 AM

This revision is now accepted and ready to land.Feb 18 2025, 11:30 AM

Closed by commit rCOMM680b5f5fa416: [web] Extract the common logic from the QR auth. · Explain WhyFeb 18 2025, 3:05 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM680b5f5fa416: [web] Extract the common logic from the QR auth.