Page MenuHomePhabricator
Differential D14393

[native] Wait with registration and restoration for the logout to conclude
ClosedPublic
Actions

Authored by tomek on Feb 20 2025, 6:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Wed, Apr 2, 2:25 PM
Unknown Object (File)
Tue, Apr 1, 7:52 PM
Unknown Object (File)
Sat, Mar 29, 5:47 AM
Unknown Object (File)
Tue, Mar 25, 5:30 PM
Unknown Object (File)
Tue, Mar 25, 7:23 AM
Unknown Object (File)
Tue, Mar 25, 6:41 AM
Unknown Object (File)
Mar 24 2025, 4:43 PM
View All 29 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMM95b84087e325: [native] Wait with registration and restoration for the logout to conclude
Summary

Show the loading state before the logout is concluded.

https://linear.app/comm/issue/ENG-10224/block-the-restoration-until-the-logout-is-concluded

Test Plan

Log out and check if the loading state is displayed. Also check that without the internet connection.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
13 lines

Diff 47179

View Options

native/account/logged-out-modal.react.js

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration." echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break break
fi fi
total_elapsed_time=$(( total_elapsed_time + retry_interval )) total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval sleep $retry_interval
done done
echo "Applying terraform changes" echo "Applying terraform changes"
terraform apply -auto-approve terraform apply -auto-approve
echo "Redisabling general lb traffic"
disable_general_lb_traffic
echo "Redeploying primary service in $cluster_name" echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null
echo "Waiting for health check at $health_check_domain to return status 200 OK" echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health check_health
echo "Primary node successfully running. Re-enabling public access to load balancer"
enable_lb_traffic
echo "Setting desired count of secondary service to $num_desired_secondary_nodes". echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null
echo "Successfully ran migration" echo "Successfully ran migration"