Differential D14406

[native] Remove position from overlay navigator
ClosedPublic
Actions

Authored by angelika on Feb 25 2025, 3:01 AM.

Details

Reviewers

tomek

Commits

rCOMMe99d6d2a3732: [native] Remove position from overlay navigator

Summary

https://linear.app/comm/issue/ENG-10006/rename-positionv2-variables-in-overlaynavigator-to-position

The position variable in OverlayNavigator is deprecated and no longer used anywhere, so we can delete it.

Test Plan

flow & run the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Feb 25 2025, 3:01 AM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 25 2025, 3:01 AM

angelika added a child revision: D14407: [native] Rename positionV2 to position in overlay navigator.Feb 25 2025, 3:02 AM

angelika published this revision for review.Feb 25 2025, 3:34 AM

Harbormaster completed remote builds in B33622: Diff 47260.Feb 25 2025, 3:37 AM

tomek accepted this revision.Feb 25 2025, 3:39 AM

This revision is now accepted and ready to land.Feb 25 2025, 3:39 AM

Closed by commit rCOMMe99d6d2a3732: [native] Remove position from overlay navigator (authored by angelika). · Explain WhyMar 3 2025, 5:57 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMe99d6d2a3732: [native] Remove position from overlay navigator.

Revision Contents
Changeset List

Path

Size

native/

navigation/

overlay-context.js

5 lines

overlay-navigator.react.js

27 lines

Diff 47330

View Options

native/navigation/overlay-context.js