Differential D14407

[native] Rename positionV2 to position in overlay navigator
ClosedPublic
Actions

Authored by angelika on Feb 25 2025, 3:02 AM.

Details

Reviewers

tomek

Commits

rCOMM0c8cb92c0d46: [native] Rename positionV2 to position in overlay navigator

Summary

https://linear.app/comm/issue/ENG-10006/rename-positionv2-variables-in-overlaynavigator-to-position

Since position variable is removed we can rename positionV2 to position in OverlayNavigator

Depends on D14406

Test Plan

Flow & run the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Feb 25 2025, 3:02 AM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 25 2025, 3:02 AM

angelika edited the summary of this revision. (Show Details)Feb 25 2025, 3:02 AM

angelika added a parent revision: D14406: [native] Remove position from overlay navigator.

angelika added a child revision: D14408: [native] Rename progressV2 variables to progress.Feb 25 2025, 3:08 AM

change positionRefsV2

angelika published this revision for review.Feb 25 2025, 3:35 AM

tomek accepted this revision.Feb 25 2025, 3:40 AM

This revision is now accepted and ready to land.Feb 25 2025, 3:40 AM

Harbormaster completed remote builds in B33623: Diff 47261.Feb 25 2025, 3:57 AM

This revision was landed with ongoing or failed builds.Mar 3 2025, 5:58 AM

Closed by commit rCOMM0c8cb92c0d46: [native] Rename positionV2 to position in overlay navigator (authored by angelika). · Explain Why

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM0c8cb92c0d46: [native] Rename positionV2 to position in overlay navigator.

Revision Contents
Changeset List

Path

Size

native/

chat/

multimedia-message-multimedia.react.js

2 lines

reaction-selection-popover.react.js

17 lines

utils.js

2 lines

components/

full-screen-view-modal.react.js

2 lines

media/

camera-modal.react.js

2 lines

video-playback-modal.react.js

2 lines

navigation/

action-result-modal.react.js

4 lines

overlay-context.js

4 lines

overlay-navigator.react.js

30 lines

tooltip/

tooltip.react.js

18 lines

Diff 47331

View Options

native/chat/multimedia-message-multimedia.react.js

View Options

native/chat/reaction-selection-popover.react.js

View Options

native/chat/utils.js

View Options

native/components/full-screen-view-modal.react.js

View Options

native/media/camera-modal.react.js

View Options

native/media/video-playback-modal.react.js

View Options

native/navigation/action-result-modal.react.js

View Options

native/navigation/overlay-context.js

View Options

native/navigation/overlay-navigator.react.js

View Options

native/tooltip/tooltip.react.js

[native] Rename positionV2 to position in overlay navigatorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47331

native/chat/multimedia-message-multimedia.react.js

native/chat/reaction-selection-popover.react.js

native/chat/utils.js

native/components/full-screen-view-modal.react.js

native/media/camera-modal.react.js

native/media/video-playback-modal.react.js

native/navigation/action-result-modal.react.js

native/navigation/overlay-context.js

native/navigation/overlay-navigator.react.js

native/tooltip/tooltip.react.js

[native] Rename positionV2 to position in overlay navigator
ClosedPublic
Actions

Revision Contents
Changeset List