Page MenuHomePhabricator
Differential D14414

[native] Fix copying encrypted images on iOS
ClosedPublic
Actions

Authored by ashoat on Feb 27 2025, 12:42 AM.
Tags
None
Referenced Files
F5120047: D14414.diff
Thu, Apr 3, 6:06 AM
Unknown Object (File)
Tue, Apr 1, 7:32 AM
Unknown Object (File)
Thu, Mar 13, 3:58 AM
Unknown Object (File)
Tue, Mar 11, 4:13 PM
Unknown Object (File)
Sun, Mar 9, 10:26 AM
Unknown Object (File)
Sat, Mar 8, 6:23 PM
Unknown Object (File)
Sat, Mar 8, 7:36 AM
Unknown Object (File)
Sat, Mar 8, 3:51 AM
View All 23 Files
Subscribers
tomek

Details

Reviewers
bartek
angelika
Commits
rCOMM66e8cbf090ee: [native] Fix copying encrypted images on iOS
Summary

This addresses ENG-10269: "Failed to copy" when trying to copy an image on iOS.

Test Plan

Confirmed that copy of an encrypted blob-hosted image works on iOS using a Release build on a physical device

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 27 2025, 12:42 AM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 27 2025, 12:42 AM
ashoat added inline comments.Feb 27 2025, 12:44 AM
native/components/full-screen-view-modal.react.js
732 ↗(On Diff #47284)

Decided the Platform check made more sense to happen in ImageModal

native/media/save-media.js
624 ↗(On Diff #47284)

Unfortunately, deleting the temp file after the copy, even on a significant delay, prevents the paste from working.

It seems like the file needs to be available the first time a paste is attempted.

It's stored in a /tmp folder within the app sandbox, so I'm hoping it's eventually deleted. @bartek, curious if you have any context on that.

bartek added a comment.Feb 27 2025, 3:29 AM

An alternative approach, that doesn't require using temporary file:

  • Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
    • For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
    • For non-encrypted, fetch base64 but don't save to file (skip last step)
  • call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116
native/media/save-media.js
624 ↗(On Diff #47284)

This is the case on Android, but I'm surprised that it happens on iOS too, given in the patch below you explicitly read the file into NSData and create an image from it. After this operation, the file shouldn't be needed anymore.

Harbormaster completed remote builds in B33638: Diff 47284.Feb 27 2025, 8:41 AM
ashoat requested review of this revision.Feb 27 2025, 8:41 AM
ashoat added a comment.Feb 27 2025, 9:07 AM
In D14414#400524, @bartek wrote:

An alternative approach, that doesn't require using temporary file:

  • Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
    • For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
    • For non-encrypted, fetch base64 but don't save to file (skip last step)
  • call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116

I'm worried about using Clipboard.setImageFromBase64 for large media files... I suspect it will be passing a massive string over the legacy React Native bridge, and so I feel obliged to do some performance testing on that, and I don't have the time to do that for an approach that I suspect might end up not working for us.

native/media/save-media.js
624 ↗(On Diff #47284)

I tested this a lot last night, including add an up to 30s delay on the file deletion. As long as the first paste occurred before the file deletion, all pastes would work. But if the file was deleted before the paste occurred, the paste would fail (even though the copy succeeded).

@bartek, can you respond to the question I asked here, specifically about whether you have any context on whether the file will be eventually deleted?

It's stored in a /tmp folder within the app sandbox, so I'm hoping it's eventually deleted. @bartek, curious if you have any context on that.

bartek accepted this revision.Feb 27 2025, 12:17 PM
In D14414#400577, @ashoat wrote:
In D14414#400524, @bartek wrote:

I'm worried about using Clipboard.setImageFromBase64 for large media files... I suspect it will be passing a massive string over the legacy React Native bridge, and so I feel obliged to do some performance testing on that, and I don't have the time to do that for an approach that I suspect might end up not working for us.

Makes sense, let's stay with file-based approach then.

native/media/save-media.js
624 ↗(On Diff #47284)

I'm sorry, I misunderstood your question, I thought you're asking me about context on clipboard behavior.

Regarding /tmp - yes, iOS periodically cleans up app sandbox temporary directories. It's unspecified when exactly, but it happens when the app is not running.

This revision is now accepted and ready to land.Feb 27 2025, 12:17 PM
Closed by commit rCOMM66e8cbf090ee: [native] Fix copying encrypted images on iOS (authored by ashoat). · Explain WhyFeb 28 2025, 1:51 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM66e8cbf090ee: [native] Fix copying encrypted images on iOS.

Revision Contents
Changeset List

Diff 47316

View Options

native/components/full-screen-view-modal.react.js

Show All 32 Lines (threadInfo, messageStore) => {
if (!thread || !viewerID || thread.messageIDs.length === 0) { if (!thread || !viewerID || thread.messageIDs.length === 0) {
return { return {
lastUpdatedAtLeastTime: threadInfo.creationTime, lastUpdatedAtLeastTime: threadInfo.creationTime,
lastUpdatedAtMostTime: threadInfo.creationTime, lastUpdatedAtMostTime: threadInfo.creationTime,
lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime), lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime),
}; };
} }
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]];
const lastUpdatedAtMostTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
// We default to the most recent message time. // We default to the most recent message time.
// - This default will only be relevant in the case that // - This default will only be relevant in the case that
// getLastUpdatedTime is implemented for every message in the loop // getLastUpdatedTime is implemented for every message in the loop
// below, and doesn't return a number for any of them. Otherwise // below, and doesn't return a number for any of them. Otherwise
// lastUpdatedAtLeastTime will be set to the most recent message that // lastUpdatedAtLeastTime will be set to the most recent message that
// returns a number, or whose message spec doesn't implement // returns a number, or whose message spec doesn't implement
// getLastUpdatedTime. // getLastUpdatedTime.
// - We default to the most recent message time because the best // - We default to the most recent message time because the best
// alternative is the thread creation time, but this is likely very // alternative is the thread creation time, but this is likely very
// far in the past. // far in the past.
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]]; let lastUpdatedAtLeastTime = lastUpdatedAtMostTime;
let lastUpdatedAtLeastTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
const getLastUpdatedTimeParams = { const getLastUpdatedTimeParams = {
threadInfo, threadInfo,
viewerID, viewerID,
getMessageAuthor: (messageID: string) => getMessageAuthor: (messageID: string) =>
baseGetMessageAuthor(messageID, messageStore), baseGetMessageAuthor(messageID, messageStore),
}; };
let lastUpdatedTime: ?() => Promise<?number>; let lastUpdatedTime: ?() => Promise<?number>;
let highestTimestamp: ?number;
for (const messageID of thread.messageIDs) { for (const messageID of thread.messageIDs) {
const messageInfo = messageStore.messages[messageID]; const messageInfo = messageStore.messages[messageID];
if (!messageInfo) { if (!messageInfo) {
continue; continue;
} }
// We call getLastUpdatedTime on the message spec. It can return either // We call getLastUpdatedTime on the message spec. It can return either
// ?number or () => Promise<?number>. If the message spec doesn't // ?number or () => Promise<?number>. If the message spec doesn't
// implement getLastUpdatedTime, then we default to messageInfo.time. // implement getLastUpdatedTime, then we default to messageInfo.time.
const { getLastUpdatedTime } = messageSpecs[messageInfo.type]; const { getLastUpdatedTime } = messageSpecs[messageInfo.type];
const lastUpdatedTimeResult = getLastUpdatedTime const lastUpdatedTimeResult = getLastUpdatedTime
? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams) ? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams)
: messageInfo.time; : messageInfo.time;
// We only need to consider the first positive number result because
// thread.messageIDs is ordered chronologically.
if (
!highestTimestamp &&
lastUpdatedTimeResult &&
typeof lastUpdatedTimeResult === 'number'
) {
highestTimestamp = lastUpdatedTimeResult;
}
// We rely on the fact that thread.messageIDs is ordered chronologically // We rely on the fact that thread.messageIDs is ordered chronologically
// (newest first) to chain together lastUpdatedTime. An older message's // (newest first) to chain together lastUpdatedTime. An older message's
// lastUpdatedTime is only considered if all of the newer messages // lastUpdatedTime is only considered if all of the newer messages
// return falsey. // return falsey.
const prevLastUpdatedTime = lastUpdatedTime; const prevLastUpdatedTime = lastUpdatedTime;
lastUpdatedTime = async () => { lastUpdatedTime = async () => {
if (prevLastUpdatedTime) { if (prevLastUpdatedTime) {
const earlierChecks = await prevLastUpdatedTime(); const earlierChecks = await prevLastUpdatedTime();
Show All 27 Lines (threadInfo, messageStore) => {
const earlierChecks = await lastUpdatedTime(); const earlierChecks = await lastUpdatedTime();
if (earlierChecks) { if (earlierChecks) {
return earlierChecks; return earlierChecks;
} }
} }
return lastUpdatedAtLeastTime; return lastUpdatedAtLeastTime;
}; };
const lastUpdatedAtMostTime = highestTimestamp ?? threadInfo.creationTime;
return { return {
lastUpdatedAtLeastTime, lastUpdatedAtLeastTime,
lastUpdatedAtMostTime, lastUpdatedAtMostTime,
lastUpdatedTime: lastUpdatedWithFallback, lastUpdatedTime: lastUpdatedWithFallback,
}; };
}, },
[viewerID, baseGetMessageAuthor], [viewerID, baseGetMessageAuthor],
); );
} }
export { useGetLastUpdatedTimes }; export { useGetLastUpdatedTimes };
View Options

native/media/image-modal.react.js

Show All 32 Lines (threadInfo, messageStore) => {
if (!thread || !viewerID || thread.messageIDs.length === 0) { if (!thread || !viewerID || thread.messageIDs.length === 0) {
return { return {
lastUpdatedAtLeastTime: threadInfo.creationTime, lastUpdatedAtLeastTime: threadInfo.creationTime,
lastUpdatedAtMostTime: threadInfo.creationTime, lastUpdatedAtMostTime: threadInfo.creationTime,
lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime), lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime),
}; };
} }
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]];
const lastUpdatedAtMostTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
// We default to the most recent message time. // We default to the most recent message time.
// - This default will only be relevant in the case that // - This default will only be relevant in the case that
// getLastUpdatedTime is implemented for every message in the loop // getLastUpdatedTime is implemented for every message in the loop
// below, and doesn't return a number for any of them. Otherwise // below, and doesn't return a number for any of them. Otherwise
// lastUpdatedAtLeastTime will be set to the most recent message that // lastUpdatedAtLeastTime will be set to the most recent message that
// returns a number, or whose message spec doesn't implement // returns a number, or whose message spec doesn't implement
// getLastUpdatedTime. // getLastUpdatedTime.
// - We default to the most recent message time because the best // - We default to the most recent message time because the best
// alternative is the thread creation time, but this is likely very // alternative is the thread creation time, but this is likely very
// far in the past. // far in the past.
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]]; let lastUpdatedAtLeastTime = lastUpdatedAtMostTime;
let lastUpdatedAtLeastTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
const getLastUpdatedTimeParams = { const getLastUpdatedTimeParams = {
threadInfo, threadInfo,
viewerID, viewerID,
getMessageAuthor: (messageID: string) => getMessageAuthor: (messageID: string) =>
baseGetMessageAuthor(messageID, messageStore), baseGetMessageAuthor(messageID, messageStore),
}; };
let lastUpdatedTime: ?() => Promise<?number>; let lastUpdatedTime: ?() => Promise<?number>;
let highestTimestamp: ?number;
for (const messageID of thread.messageIDs) { for (const messageID of thread.messageIDs) {
const messageInfo = messageStore.messages[messageID]; const messageInfo = messageStore.messages[messageID];
if (!messageInfo) { if (!messageInfo) {
continue; continue;
} }
// We call getLastUpdatedTime on the message spec. It can return either // We call getLastUpdatedTime on the message spec. It can return either
// ?number or () => Promise<?number>. If the message spec doesn't // ?number or () => Promise<?number>. If the message spec doesn't
// implement getLastUpdatedTime, then we default to messageInfo.time. // implement getLastUpdatedTime, then we default to messageInfo.time.
const { getLastUpdatedTime } = messageSpecs[messageInfo.type]; const { getLastUpdatedTime } = messageSpecs[messageInfo.type];
const lastUpdatedTimeResult = getLastUpdatedTime const lastUpdatedTimeResult = getLastUpdatedTime
? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams) ? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams)
: messageInfo.time; : messageInfo.time;
// We only need to consider the first positive number result because
// thread.messageIDs is ordered chronologically.
if (
!highestTimestamp &&
lastUpdatedTimeResult &&
typeof lastUpdatedTimeResult === 'number'
) {
highestTimestamp = lastUpdatedTimeResult;
}
// We rely on the fact that thread.messageIDs is ordered chronologically // We rely on the fact that thread.messageIDs is ordered chronologically
// (newest first) to chain together lastUpdatedTime. An older message's // (newest first) to chain together lastUpdatedTime. An older message's
// lastUpdatedTime is only considered if all of the newer messages // lastUpdatedTime is only considered if all of the newer messages
// return falsey. // return falsey.
const prevLastUpdatedTime = lastUpdatedTime; const prevLastUpdatedTime = lastUpdatedTime;
lastUpdatedTime = async () => { lastUpdatedTime = async () => {
if (prevLastUpdatedTime) { if (prevLastUpdatedTime) {
const earlierChecks = await prevLastUpdatedTime(); const earlierChecks = await prevLastUpdatedTime();
Show All 27 Lines (threadInfo, messageStore) => {
const earlierChecks = await lastUpdatedTime(); const earlierChecks = await lastUpdatedTime();
if (earlierChecks) { if (earlierChecks) {
return earlierChecks; return earlierChecks;
} }
} }
return lastUpdatedAtLeastTime; return lastUpdatedAtLeastTime;
}; };
const lastUpdatedAtMostTime = highestTimestamp ?? threadInfo.creationTime;
return { return {
lastUpdatedAtLeastTime, lastUpdatedAtLeastTime,
lastUpdatedAtMostTime, lastUpdatedAtMostTime,
lastUpdatedTime: lastUpdatedWithFallback, lastUpdatedTime: lastUpdatedWithFallback,
}; };
}, },
[viewerID, baseGetMessageAuthor], [viewerID, baseGetMessageAuthor],
); );
} }
export { useGetLastUpdatedTimes }; export { useGetLastUpdatedTimes };
View Options

native/media/save-media.js

Show All 32 Lines (threadInfo, messageStore) => {
if (!thread || !viewerID || thread.messageIDs.length === 0) { if (!thread || !viewerID || thread.messageIDs.length === 0) {
return { return {
lastUpdatedAtLeastTime: threadInfo.creationTime, lastUpdatedAtLeastTime: threadInfo.creationTime,
lastUpdatedAtMostTime: threadInfo.creationTime, lastUpdatedAtMostTime: threadInfo.creationTime,
lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime), lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime),
}; };
} }
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]];
const lastUpdatedAtMostTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
// We default to the most recent message time. // We default to the most recent message time.
// - This default will only be relevant in the case that // - This default will only be relevant in the case that
// getLastUpdatedTime is implemented for every message in the loop // getLastUpdatedTime is implemented for every message in the loop
// below, and doesn't return a number for any of them. Otherwise // below, and doesn't return a number for any of them. Otherwise
// lastUpdatedAtLeastTime will be set to the most recent message that // lastUpdatedAtLeastTime will be set to the most recent message that
// returns a number, or whose message spec doesn't implement // returns a number, or whose message spec doesn't implement
// getLastUpdatedTime. // getLastUpdatedTime.
// - We default to the most recent message time because the best // - We default to the most recent message time because the best
// alternative is the thread creation time, but this is likely very // alternative is the thread creation time, but this is likely very
// far in the past. // far in the past.
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]]; let lastUpdatedAtLeastTime = lastUpdatedAtMostTime;
let lastUpdatedAtLeastTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
const getLastUpdatedTimeParams = { const getLastUpdatedTimeParams = {
threadInfo, threadInfo,
viewerID, viewerID,
getMessageAuthor: (messageID: string) => getMessageAuthor: (messageID: string) =>
baseGetMessageAuthor(messageID, messageStore), baseGetMessageAuthor(messageID, messageStore),
}; };
let lastUpdatedTime: ?() => Promise<?number>; let lastUpdatedTime: ?() => Promise<?number>;
let highestTimestamp: ?number;
for (const messageID of thread.messageIDs) { for (const messageID of thread.messageIDs) {
const messageInfo = messageStore.messages[messageID]; const messageInfo = messageStore.messages[messageID];
if (!messageInfo) { if (!messageInfo) {
continue; continue;
} }
// We call getLastUpdatedTime on the message spec. It can return either // We call getLastUpdatedTime on the message spec. It can return either
// ?number or () => Promise<?number>. If the message spec doesn't // ?number or () => Promise<?number>. If the message spec doesn't
// implement getLastUpdatedTime, then we default to messageInfo.time. // implement getLastUpdatedTime, then we default to messageInfo.time.
const { getLastUpdatedTime } = messageSpecs[messageInfo.type]; const { getLastUpdatedTime } = messageSpecs[messageInfo.type];
const lastUpdatedTimeResult = getLastUpdatedTime const lastUpdatedTimeResult = getLastUpdatedTime
? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams) ? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams)
: messageInfo.time; : messageInfo.time;
// We only need to consider the first positive number result because
// thread.messageIDs is ordered chronologically.
if (
!highestTimestamp &&
lastUpdatedTimeResult &&
typeof lastUpdatedTimeResult === 'number'
) {
highestTimestamp = lastUpdatedTimeResult;
}
// We rely on the fact that thread.messageIDs is ordered chronologically // We rely on the fact that thread.messageIDs is ordered chronologically
// (newest first) to chain together lastUpdatedTime. An older message's // (newest first) to chain together lastUpdatedTime. An older message's
// lastUpdatedTime is only considered if all of the newer messages // lastUpdatedTime is only considered if all of the newer messages
// return falsey. // return falsey.
const prevLastUpdatedTime = lastUpdatedTime; const prevLastUpdatedTime = lastUpdatedTime;
lastUpdatedTime = async () => { lastUpdatedTime = async () => {
if (prevLastUpdatedTime) { if (prevLastUpdatedTime) {
const earlierChecks = await prevLastUpdatedTime(); const earlierChecks = await prevLastUpdatedTime();
Show All 27 Lines (threadInfo, messageStore) => {
const earlierChecks = await lastUpdatedTime(); const earlierChecks = await lastUpdatedTime();
if (earlierChecks) { if (earlierChecks) {
return earlierChecks; return earlierChecks;
} }
} }
return lastUpdatedAtLeastTime; return lastUpdatedAtLeastTime;
}; };
const lastUpdatedAtMostTime = highestTimestamp ?? threadInfo.creationTime;
return { return {
lastUpdatedAtLeastTime, lastUpdatedAtLeastTime,
lastUpdatedAtMostTime, lastUpdatedAtMostTime,
lastUpdatedTime: lastUpdatedWithFallback, lastUpdatedTime: lastUpdatedWithFallback,
}; };
}, },
[viewerID, baseGetMessageAuthor], [viewerID, baseGetMessageAuthor],
); );
} }
export { useGetLastUpdatedTimes }; export { useGetLastUpdatedTimes };
View Options

patches/@react-native-clipboard+clipboard+1.11.1.patch

Show All 32 Lines (threadInfo, messageStore) => {
if (!thread || !viewerID || thread.messageIDs.length === 0) { if (!thread || !viewerID || thread.messageIDs.length === 0) {
return { return {
lastUpdatedAtLeastTime: threadInfo.creationTime, lastUpdatedAtLeastTime: threadInfo.creationTime,
lastUpdatedAtMostTime: threadInfo.creationTime, lastUpdatedAtMostTime: threadInfo.creationTime,
lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime), lastUpdatedTime: () => Promise.resolve(threadInfo.creationTime),
}; };
} }
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]];
const lastUpdatedAtMostTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
// We default to the most recent message time. // We default to the most recent message time.
// - This default will only be relevant in the case that // - This default will only be relevant in the case that
// getLastUpdatedTime is implemented for every message in the loop // getLastUpdatedTime is implemented for every message in the loop
// below, and doesn't return a number for any of them. Otherwise // below, and doesn't return a number for any of them. Otherwise
// lastUpdatedAtLeastTime will be set to the most recent message that // lastUpdatedAtLeastTime will be set to the most recent message that
// returns a number, or whose message spec doesn't implement // returns a number, or whose message spec doesn't implement
// getLastUpdatedTime. // getLastUpdatedTime.
// - We default to the most recent message time because the best // - We default to the most recent message time because the best
// alternative is the thread creation time, but this is likely very // alternative is the thread creation time, but this is likely very
// far in the past. // far in the past.
const mostRecentMessage = messageStore.messages[thread.messageIDs[0]]; let lastUpdatedAtLeastTime = lastUpdatedAtMostTime;
let lastUpdatedAtLeastTime =
mostRecentMessage?.time ?? threadInfo.creationTime;
const getLastUpdatedTimeParams = { const getLastUpdatedTimeParams = {
threadInfo, threadInfo,
viewerID, viewerID,
getMessageAuthor: (messageID: string) => getMessageAuthor: (messageID: string) =>
baseGetMessageAuthor(messageID, messageStore), baseGetMessageAuthor(messageID, messageStore),
}; };
let lastUpdatedTime: ?() => Promise<?number>; let lastUpdatedTime: ?() => Promise<?number>;
let highestTimestamp: ?number;
for (const messageID of thread.messageIDs) { for (const messageID of thread.messageIDs) {
const messageInfo = messageStore.messages[messageID]; const messageInfo = messageStore.messages[messageID];
if (!messageInfo) { if (!messageInfo) {
continue; continue;
} }
// We call getLastUpdatedTime on the message spec. It can return either // We call getLastUpdatedTime on the message spec. It can return either
// ?number or () => Promise<?number>. If the message spec doesn't // ?number or () => Promise<?number>. If the message spec doesn't
// implement getLastUpdatedTime, then we default to messageInfo.time. // implement getLastUpdatedTime, then we default to messageInfo.time.
const { getLastUpdatedTime } = messageSpecs[messageInfo.type]; const { getLastUpdatedTime } = messageSpecs[messageInfo.type];
const lastUpdatedTimeResult = getLastUpdatedTime const lastUpdatedTimeResult = getLastUpdatedTime
? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams) ? getLastUpdatedTime(messageInfo, getLastUpdatedTimeParams)
: messageInfo.time; : messageInfo.time;
// We only need to consider the first positive number result because
// thread.messageIDs is ordered chronologically.
if (
!highestTimestamp &&
lastUpdatedTimeResult &&
typeof lastUpdatedTimeResult === 'number'
) {
highestTimestamp = lastUpdatedTimeResult;
}
// We rely on the fact that thread.messageIDs is ordered chronologically // We rely on the fact that thread.messageIDs is ordered chronologically
// (newest first) to chain together lastUpdatedTime. An older message's // (newest first) to chain together lastUpdatedTime. An older message's
// lastUpdatedTime is only considered if all of the newer messages // lastUpdatedTime is only considered if all of the newer messages
// return falsey. // return falsey.
const prevLastUpdatedTime = lastUpdatedTime; const prevLastUpdatedTime = lastUpdatedTime;
lastUpdatedTime = async () => { lastUpdatedTime = async () => {
if (prevLastUpdatedTime) { if (prevLastUpdatedTime) {
const earlierChecks = await prevLastUpdatedTime(); const earlierChecks = await prevLastUpdatedTime();
Show All 27 Lines (threadInfo, messageStore) => {
const earlierChecks = await lastUpdatedTime(); const earlierChecks = await lastUpdatedTime();
if (earlierChecks) { if (earlierChecks) {
return earlierChecks; return earlierChecks;
} }
} }
return lastUpdatedAtLeastTime; return lastUpdatedAtLeastTime;
}; };
const lastUpdatedAtMostTime = highestTimestamp ?? threadInfo.creationTime;
return { return {
lastUpdatedAtLeastTime, lastUpdatedAtLeastTime,
lastUpdatedAtMostTime, lastUpdatedAtMostTime,
lastUpdatedTime: lastUpdatedWithFallback, lastUpdatedTime: lastUpdatedWithFallback,
}; };
}, },
[viewerID, baseGetMessageAuthor], [viewerID, baseGetMessageAuthor],
); );
} }
export { useGetLastUpdatedTimes }; export { useGetLastUpdatedTimes };