Page MenuHomePhabricator
Differential D14464

[keyserver] call `free()` on Olm objects in finally block
ClosedPublic
Actions

Authored by kamil on Wed, Mar 19, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 7:06 PM
Unknown Object (File)
Sun, Apr 6, 3:32 PM
Unknown Object (File)
Sun, Apr 6, 6:48 AM
Unknown Object (File)
Sun, Apr 6, 4:19 AM
Unknown Object (File)
Sun, Apr 6, 4:09 AM
Unknown Object (File)
Thu, Apr 3, 5:03 AM
Unknown Object (File)
Wed, Apr 2, 10:32 PM
Unknown Object (File)
Wed, Apr 2, 10:32 PM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
ashoat
Commits
rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block
Summary

Some context in ENG-10393

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Mar 19, 10:03 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Mar 19, 10:03 AM
ashoat published this revision for review.Wed, Mar 19, 10:06 AM
ashoat added inline comments.
keyserver/src/utils/olm-objects.js
30 ↗(On Diff #47474)

Don’t need to declare here

32 ↗(On Diff #47474)

Can be const result here

80 ↗(On Diff #47474)

Same here

ashoat accepted this revision.Wed, Mar 19, 10:06 AM
This revision is now accepted and ready to land.Wed, Mar 19, 10:06 AM
Harbormaster completed remote builds in B33770: Diff 47474.Wed, Mar 19, 10:33 AM
bartek accepted this revision.Wed, Mar 19, 11:56 AM
kamil updated this revision to Diff 47493.Thu, Mar 20, 4:58 AM

review comments

kamil added a child revision: D14482: [web] clear old `cryptoStore` before creating new one.Thu, Mar 20, 4:59 AM
Harbormaster completed remote builds in B33789: Diff 47493.Thu, Mar 20, 5:29 AM
Closed by commit rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block (authored by kamil). · Explain WhyThu, Mar 20, 6:21 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
45 lines

Diff 47506

View Options

keyserver/src/utils/olm-objects.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines