[keyserver] call `free()` on Olm objects in finally block
ClosedPublic
Actions

Authored by kamil on Mar 19 2025, 5:03 PM.

Details

Reviewers

bartek
tomek
ashoat

Commits

rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block

Summary

Some context in ENG-10393

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 19 2025, 5:03 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 19 2025, 5:03 PM

ashoat published this revision for review.Mar 19 2025, 5:06 PM

ashoat added inline comments.

keyserver/src/utils/olm-objects.js
30 ↗	(On Diff #47474)	Don’t need to declare here
32 ↗	(On Diff #47474)	Can be const result here
80 ↗	(On Diff #47474)	Same here

ashoat accepted this revision.Mar 19 2025, 5:06 PM

This revision is now accepted and ready to land.Mar 19 2025, 5:06 PM

Harbormaster completed remote builds in B33770: Diff 47474.Mar 19 2025, 5:33 PM

bartek accepted this revision.Mar 19 2025, 6:56 PM

review comments

kamil added a child revision: D14482: [web] clear old `cryptoStore` before creating new one.Mar 20 2025, 11:59 AM

Harbormaster completed remote builds in B33789: Diff 47493.Mar 20 2025, 12:29 PM

Closed by commit rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block. · Explain WhyMar 20 2025, 1:21 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

olm-objects.js

45 lines

Diff 47506

View Options

keyserver/src/utils/olm-objects.js

[keyserver] call `free()` on Olm objects in finally blockClosedPublicActions