Page MenuHomePhabricator
Differential D14488

[native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed
Changes PlannedPublic
Actions

Authored by varun on Sun, Mar 23, 9:22 AM.
Tags
None
Referenced Files
F5107462: D14488.id47578.diff
Tue, Apr 1, 11:08 AM
Unknown Object (File)
Mon, Mar 31, 8:58 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 6:06 PM
Unknown Object (File)
Fri, Mar 28, 6:06 PM
Unknown Object (File)
Fri, Mar 28, 12:44 PM
Unknown Object (File)
Fri, Mar 28, 8:49 AM
Unknown Object (File)
Thu, Mar 27, 11:33 PM
View All 15 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

with this change, the connect farcaster prompt appears after all the nux tips have been dismissed, instead of simultaneously

Depends on D14446

Test Plan

tested on release build

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sun, Mar 23, 9:22 AM
Herald added a subscriber: tomek. · View Herald TranscriptSun, Mar 23, 9:22 AM
varun published this revision for review.Sun, Mar 23, 9:25 AM
varun updated this revision to Diff 47578.Wed, Mar 26, 7:55 PM
  1. use coldStartCount to make sure we don't display connect farcaster alert right after NUX
  2. use connectFarcasterAlertInfo in DisplayCommunityDirectoryPromptHandler to make sure we don't display community directory prompt until a day after connect farcaster prompt
Harbormaster completed remote builds in B33850: Diff 47578.Wed, Mar 26, 8:13 PM
ashoat requested changes to this revision.EditedWed, Mar 26, 8:51 PM

Your test plan is super incomplete. Can you please update the test plan to go one-by-one through every scenario we've had to contemplate while working on this? Eg. fresh registration, log in of existing user with Farcaster connection, log in of existing user with no Farcaster connection, existing log-in that hasn't logged out since before the new registration flow (never got prompted to connect Farcaster), etc.

native/components/display-community-directory-prompt.react.js
64 ↗(On Diff #47578)

Won't this check make it so users that register and get fid set to something other than undefined (and consequently never get the connect Farcaster prompt) will never see the community directory?

This revision now requires changes to proceed.Wed, Mar 26, 8:51 PM
varun updated this revision to Diff 47614.Mon, Mar 31, 3:42 PM

make cold start count a per-alert type count instead of a global count, migrations, stagger the connect farcaster and community directory prompts

varun planned changes to this revision.Mon, Mar 31, 3:42 PM

need to finish testing this

Harbormaster failed remote builds in B33865: Diff 47614!Mon, Mar 31, 3:50 PM

Revision Contents
Changeset List

PathSize
lib/
utils/
2 lines
native/
components/
10 lines
ios/
2 lines

Diff 47522

View Options

lib/utils/farcaster-utils.js

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

native/components/connect-farcaster-alert-handler.react.js

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

native/ios/Podfile.lock

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines