Page MenuHomePhabricator
Differential D14488

[native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed
Changes PlannedPublic
Actions

Authored by varun on Sun, Mar 23, 9:22 AM.
Tags
None
Referenced Files
F5120882: D14488.id.diff
Thu, Apr 3, 8:59 AM
F5119694: D14488.id47614.diff
Thu, Apr 3, 4:29 AM
Unknown Object (File)
Wed, Apr 2, 3:12 PM
Unknown Object (File)
Tue, Apr 1, 11:08 AM
Unknown Object (File)
Mon, Mar 31, 8:58 PM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 6:06 PM
Unknown Object (File)
Fri, Mar 28, 6:06 PM
View All 18 Files
Subscribers
tomek

Details

Reviewers
ashoat
Summary

with this change, the connect farcaster prompt appears after all the nux tips have been dismissed, instead of simultaneously

Depends on D14446

Test Plan

tested on release build

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sun, Mar 23, 9:22 AM
Herald added a subscriber: tomek. · View Herald TranscriptSun, Mar 23, 9:22 AM
varun published this revision for review.Sun, Mar 23, 9:25 AM
varun updated this revision to Diff 47578.Wed, Mar 26, 7:55 PM
  1. use coldStartCount to make sure we don't display connect farcaster alert right after NUX
  2. use connectFarcasterAlertInfo in DisplayCommunityDirectoryPromptHandler to make sure we don't display community directory prompt until a day after connect farcaster prompt
Harbormaster completed remote builds in B33850: Diff 47578.Wed, Mar 26, 8:13 PM
ashoat requested changes to this revision.EditedWed, Mar 26, 8:51 PM

Your test plan is super incomplete. Can you please update the test plan to go one-by-one through every scenario we've had to contemplate while working on this? Eg. fresh registration, log in of existing user with Farcaster connection, log in of existing user with no Farcaster connection, existing log-in that hasn't logged out since before the new registration flow (never got prompted to connect Farcaster), etc.

native/components/display-community-directory-prompt.react.js
64

Won't this check make it so users that register and get fid set to something other than undefined (and consequently never get the connect Farcaster prompt) will never see the community directory?

This revision now requires changes to proceed.Wed, Mar 26, 8:51 PM
varun updated this revision to Diff 47614.Mon, Mar 31, 3:42 PM

make cold start count a per-alert type count instead of a global count, migrations, stagger the connect farcaster and community directory prompts

varun planned changes to this revision.Mon, Mar 31, 3:42 PM

need to finish testing this

Harbormaster failed remote builds in B33865: Diff 47614!Mon, Mar 31, 3:50 PM

Revision Contents
Changeset List

Diff 47578

View Options

lib/utils/date-utils.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

lib/utils/farcaster-utils.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

native/components/connect-farcaster-alert-handler.react.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

native/components/display-community-directory-prompt.react.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

native/ios/Podfile.lock

Loading...