Page MenuHomePhabricator

[lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages
ClosedPublic

Authored by ashoat on Mon, Mar 24, 8:10 AM.
Tags
None
Referenced Files
F5120829: D14494.diff
Thu, Apr 3, 8:46 AM
F5116159: D14494.id47542.diff
Wed, Apr 2, 2:22 PM
Unknown Object (File)
Wed, Apr 2, 2:23 AM
Unknown Object (File)
Mon, Mar 31, 8:36 PM
Unknown Object (File)
Mon, Mar 31, 10:45 AM
Unknown Object (File)
Sun, Mar 30, 9:12 PM
Unknown Object (File)
Sun, Mar 30, 4:02 PM
Unknown Object (File)
Sat, Mar 29, 7:38 AM
Subscribers
None

Details

Summary

Currently, we fall back to threadInfo.creationTime in cases where none of the messages return a concrete time.

I think that behavior isn't great. It tends to happen when we only have a single most recent message for a given thin thread, but in those cases threadInfo.creationTime can be way earlier than the recent messages.

This diff changes the behavior so that if none of the messages return a concrete time, we'll fall back to the most recent message timestamp instead. We'll only use threadInfo.creationTime if we have no alternatives.

Depends on D14493

Test Plan

I tested this along with the rest of the stack by making sure that everything still worked on my physical device with a release build, and that performance was not degraded

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable