Page MenuHomePhabricator

[lib] Only use threadInfo.creationTime for lastUpdatedTime if no messages
ClosedPublic

Authored by ashoat on Mar 24 2025, 8:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 1:52 AM
Unknown Object (File)
Thu, Apr 17, 9:44 PM
Unknown Object (File)
Thu, Apr 17, 9:44 PM
Unknown Object (File)
Thu, Apr 17, 9:44 PM
Unknown Object (File)
Mon, Apr 14, 4:23 PM
Unknown Object (File)
Mon, Apr 14, 4:23 PM
Unknown Object (File)
Mon, Apr 14, 4:23 PM
Unknown Object (File)
Fri, Apr 11, 11:39 AM
Subscribers
None

Details

Summary

Currently, we fall back to threadInfo.creationTime in cases where none of the messages return a concrete time.

I think that behavior isn't great. It tends to happen when we only have a single most recent message for a given thin thread, but in those cases threadInfo.creationTime can be way earlier than the recent messages.

This diff changes the behavior so that if none of the messages return a concrete time, we'll fall back to the most recent message timestamp instead. We'll only use threadInfo.creationTime if we have no alternatives.

Depends on D14493

Test Plan

I tested this along with the rest of the stack by making sure that everything still worked on my physical device with a release build, and that performance was not degraded

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/robotextnoise
Lint
No Lint Coverage
Unit
No Test Coverage