Attempt to fix ENG-10307.
Added a global variable that tracks database deletion/reset status. Any naming suggestions appreciated.
Details
Details
Artificially added delay before calling sharedWorker.init() in handleSensitiveData on web, to simulate the race.
Without awaiting waitUntilDatabaseDeletion() before QR generation, I was getting outdated deviceID. When awaiting, the deviceID is correct.
With this change, I wasn't able to reproduce the original issue anymore.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/components/secondary-device-qr-auth-context-provider.react.js | ||
|---|---|---|
| 96–98 ↗ | (On Diff #47693) | I would probably move this into a helper function inside wait-until-db-deleted.js. That way you can avoid implementing getDatabaseResetStatus() and just use currentDatabaseStatus directly. You could name the function waitUntilDatabaseReady() |
| lib/utils/wait-until-db-deleted.js | ||
| 4–5 ↗ | (On Diff #47693) | Nit: we usually format these enums differently |
| 10 ↗ | (On Diff #47693) | I would move this down, closer to where it's used |
| lib/components/secondary-device-qr-auth-context-provider.react.js | ||
|---|---|---|
| 96–98 ↗ | (On Diff #47693) | Good idea, thank you |
| lib/utils/wait-until-db-deleted.js | ||
| 4–5 ↗ | (On Diff #47693) | Then we should also change the casing in https://github.com/CommE2E/comm/blob/bf675a9276e5b7ef670a5b0d8b9574127ac30fa2/web/shared-worker/shared-worker-provider.js#L29 I can do it in another diff |
Comment Actions
Address review feedback:
- Enum casing
- Declaration reorder
- Introduced waitUntilDatabaseReady()