Delete all the usages of the flag and all the code that was executed when this flag was false.
https://linear.app/comm/issue/ENG-6415/deprecate-usingcommservicesaccesstoken
Depends on D14579
Details
Details
Flow. Tested with the rest of the stack:
- Registered a new account on native
- Wiped the state
- Restored the account
- Logged in on web
- Checked that the app works by sending some messages in thick threads
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/keyserver-conn/call-keyserver-endpoint-provider.react.js | ||
|---|---|---|
| 145 ↗ | (On Diff #47810) | After this refactoring canResolveKeyserverSessionInvalidation always returns true, so it can also be removed. |
| lib/actions/user-actions.js | ||
|---|---|---|
| 1294–1298 ↗ | (On Diff #47810) | Can we remove legacyLogIn and the types now? |
| 1301–1303 ↗ | (On Diff #47810) | Can we remove it now from lib/types/redux-types.js? |
Comment Actions
Delete from Redux types
| lib/actions/user-actions.js | ||
|---|---|---|
| 1294–1298 ↗ | (On Diff #47810) | Maybe, but that wouldn't be simple. It is used in resolveKeyserverSessionInvalidationUsingNativeCredentials as legacyLogInRawAction that is still used in recoverDataFromAuthoritativeKeyserver inside SQLiteDataHandler. This code is executed in an effect when databaseNeedsDeletion. Not sure if it is useful in this case, but figuring everything out feels complicated. |
| 1301–1303 ↗ | (On Diff #47810) | Good point! |