We should avoid broadcasting a message to peers if the deletion doesn't succeed on Identity.
Details
Tried deleting an account with an incorrect password - an alert was shown but the message wasn't broadcasted. Deleting with the correct password still works.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/actions/user-actions.js | ||
|---|---|---|
| 620–625 ↗ | (On Diff #48211) | Two notes:
|
| lib/actions/user-actions.js | ||
|---|---|---|
| 620–625 ↗ | (On Diff #48211) |
The idea of broadcasting the message before calling Identity was motivated exactly by this reasoning. We wanted peers to increase the chance of receiving the message while the peer was still on Identity to create a session if it doesn't exist potentially. However, as you noticed, they can still be too late because the RPC is processed relatively fast, so your change doesn't make it much worse in this matter. |