Details

Reviewers

tomek
kamil

Commits

rCOMM09f288c96a1d: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs

Summary

Part of ENG-10782.
Connected Identity Client JS layer API with RPC calls.

Now identityClient.getOutboundKeys() has optional selectedDeviceIDs param to specify for which devices we want to retrieve keys.

Depends on D14759

Test Plan

On both native and web, hardcoded getOutboundKeys call in an one-off useEffect, observed response. Tested with and without specifying a filter.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 26 2025, 8:47 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 26 2025, 8:47 AM

Rebase

Harbormaster failed remote builds in B34253: Diff 48216!May 26 2025, 9:12 AM

Rebase fix

Harbormaster failed remote builds in B34256: Diff 48219!May 26 2025, 9:34 AM

Harbormaster failed remote builds in B34257: Diff 48220!May 26 2025, 10:24 AM

Another rebase

bartek published this revision for review.May 26 2025, 12:21 PM

Harbormaster completed remote builds in B34268: Diff 48232.May 26 2025, 12:57 PM

kamil accepted this revision.May 27 2025, 8:51 AM

This revision is now accepted and ready to land.May 27 2025, 8:51 AM

tomek accepted this revision.May 27 2025, 11:20 AM

Closed by commit rCOMM09f288c96a1d: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs. · Explain WhyMay 28 2025, 10:36 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM09f288c96a1d: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs.

[web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 48320

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/x3dh.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

web/grpc/identity-service-client-wrapper.js

[web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48320

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/x3dh.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

web/grpc/identity-service-client-wrapper.js

[web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs
ClosedPublic
Actions

Revision Contents
Changeset List