[native] Use AsyncMutex for logs
ClosedPublic
Actions

Authored by bartek on Jun 2 2025, 9:29 AM.

Details

Reviewers

kamil

Commits

rCOMM81087fc2d418: [native] Use AsyncMutex for logs

Summary

Noticed this when working on ENG-10523.
When using std::sync::Mutex, we block the whole thread (possibly multiple async tasks) on it.
Replaced it with tokio::sync::Mutex as AsyncMutex which blocks only current Tokio task asynchronously.

Depends on D14786

Test Plan

Tested together with D14786 test plan - logs are uploaded correctly, no race conditions and deadlocks.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 2 2025, 9:29 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2025, 9:29 AM

bartek published this revision for review.Jun 2 2025, 9:34 AM

Harbormaster completed remote builds in B34335: Diff 48359.Jun 2 2025, 9:49 AM

kamil accepted this revision.Jun 2 2025, 2:51 PM

This revision is now accepted and ready to land.Jun 2 2025, 2:51 PM

Closed by commit rCOMM81087fc2d418: [native] Use AsyncMutex for logs. · Explain WhyJun 4 2025, 10:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM81087fc2d418: [native] Use AsyncMutex for logs.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

19 lines

Diff 48423

View Options

native/native_rust_library/src/backup/upload_handler.rs

[native] Use AsyncMutex for logsClosedPublicActions