Paths

Table of Contentst

Differential D14797

[native] Update Rust functions to use random backup keys
ClosedPublic
Actions

Authored by bartek on Jun 2 2025, 10:56 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMeaab174a6946: [native] Update Rust functions to use random backup keys

Summary

Part of ENG-10519.
Updated Rust functions which create UserKeys backup to be able to generate random backup keys when creating a new compaction.

Depends on D14796

Test Plan

Tested together with the next diff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 2 2025, 10:56 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2025, 10:56 AM

bartek added a child revision: D14798: [native] Update createMainCompaction to use random backup keys.Jun 2 2025, 11:02 AM

Harbormaster completed remote builds in B34341: Diff 48388.Jun 2 2025, 11:13 AM

bartek published this revision for review.Jun 2 2025, 11:31 AM

bartek added inline comments.

native/native_rust_library/src/backup.rs
98 ↗	(On Diff #48388)	This (`use_random_keys`) is set to `true` in the next diff.
134 ↗	(On Diff #48388)	We don't generate new random keys in UserKeys-only backup
319–329 ↗	(On Diff #48388)	Generally, I think this could be factored upwards to the top-level calls but I didn't want to make too many changes in this diff
375–376 ↗	(On Diff #48388)	This is called in UserKeys restore, we don't want to use random keys here but keep existing behavior which is reading from SecureStore

kamil accepted this revision.Jun 2 2025, 12:38 PM

This revision is now accepted and ready to land.Jun 2 2025, 12:38 PM

Closed by commit rCOMMeaab174a6946: [native] Update Rust functions to use random backup keys. · Explain WhyJun 2 2025, 2:04 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMeaab174a6946: [native] Update Rust functions to use random backup keys.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

63 lines

Diff 48401

native/native_rust_library/src/backup.rs

Loading...