Details

Reviewers

kamil

Commits

rCOMM3a14cd77be14: [native] Add backup version info path to PlatformSpecificTools

Summary

Part of ENG-10771.
Need this to pass DB version info to backup upload handler thread.

This is temporary quick approach, a cleaner version is proposed in ENG-10771.

Test Plan

Tested in the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 2 2025, 12:52 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2025, 12:52 PM

bartek added a child revision: D14800: [native] Upload DB version with backup info.Jun 2 2025, 12:58 PM

Fix android

Harbormaster failed remote builds in B34344: Diff 48392!Jun 2 2025, 1:36 PM

Harbormaster failed remote builds in B34348: Diff 48396!Jun 2 2025, 1:54 PM

Rebase

Harbormaster failed remote builds in B34350: Diff 48398!Jun 2 2025, 2:21 PM

Rebase on cleaninstall

Harbormaster completed remote builds in B34352: Diff 48403.Jun 2 2025, 3:09 PM

bartek published this revision for review.Jun 2 2025, 3:32 PM

This comment has been deleted.

This revision is now accepted and ready to land.Jun 3 2025, 10:07 AM

Closed by commit rCOMM3a14cd77be14: [native] Add backup version info path to PlatformSpecificTools. · Explain WhyJun 4 2025, 10:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3a14cd77be14: [native] Add backup version info path to PlatformSpecificTools.

[native] Add backup version info path to PlatformSpecificTools
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 48422

native/android/app/src/cpp/PlatformSpecificTools.cpp

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

native/ios/Comm/PlatformSpecificTools.mm

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/backup/upload_handler.rs

native/native_rust_library/src/lib.rs

[native] Add backup version info path to PlatformSpecificToolsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48422

native/android/app/src/cpp/PlatformSpecificTools.cpp

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

native/ios/Comm/PlatformSpecificTools.mm

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/backup/upload_handler.rs

native/native_rust_library/src/lib.rs

[native] Add backup version info path to PlatformSpecificTools
ClosedPublic
Actions

Revision Contents
Changeset List